Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differenent cache capabilities at different OCPL sites #579

Open
following5 opened this issue Jan 17, 2019 · 2 comments
Open

Differenent cache capabilities at different OCPL sites #579

following5 opened this issue Jan 17, 2019 · 2 comments

Comments

@following5
Copy link
Contributor

This is closely related to #578 and blocks #570.

OCPL sites have different sets of cache sizes, but services/caches/capabilities currently ignores that. It returns the same set of basic sizes for all OCPL sites. (This is uncritical as long as full cache editing is not deployed. Also, so far no client did query the capabilities.)

In the future, this may also apply to cache types. Theoretically also to cache countries, regions and description languages.

OCPL cache sizes and types currently are redunantly definied in code and in (legacy) DB tables. For sizes, it currently is proposed to consolidate that to the code (=> Config/site.*.php). How can OKAPI access those definitions?

Easiest solution for OKAPI would be if the OCPL DB tables are retained and automatically maintained via new database update system (update them with each code deployment). Then we can handle it the same for OCPL and OCDE. Only the id fields would accessed by OKAPI.

@following5
Copy link
Contributor Author

Removed services/caches/capabilities by 72e03f7, and restored old search docs.

@andrixnet
Copy link
Contributor

andrixnet commented Apr 25, 2019

I think maintaining the same information in multiple places is a bad idea.
Since opencaching-pl has begun moving data definitions to code, this should be a general rule, not a another mixture.

IMO the code [opencaching-pl] should define all possible cache types, all possible sizes, all possible attributes, etc.
Settings for individual nodes (websites) should enable or disable their desired features.
The code should have a method to report enabled features for this instance, according to configuration, method accessible to OKAPI to obtain the necessary information.

However duplicating definitions from the code into a database table is needless complication of code, database, website and database performance and ultimately user experience.

@following5 following5 removed their assignment Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants