Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC log types #7

Open
following5 opened this issue Sep 18, 2017 · 5 comments
Open

OC log types #7

following5 opened this issue Sep 18, 2017 · 5 comments

Comments

@following5
Copy link
Contributor

following5 commented Sep 18, 2017

andrixnet suggested in opencaching/okapi#511 to add an element for OC log types.

@andrixnet: Which log types to you have in mind? I could only find these two which have no GC counterparts:

  • OCPL "OC Team comment"
  • OCDE "Locked"

For "OC Team comment", I would prefer a flag, because it can be combined with any type of OCDE log (and it is a flag in OKAPI, too). An OCPL team comment then would be a GC "Write note" + oc:team_comment flag.

The OCDE "Locked" log type is of little relevance. Users will very rarely download GPX data of a locked cache (in OKAPI it's not possible at all), and it's also very rare the a locked cache comes back to life. For these very rare cases, I think it's ok to have the log type as "Archived" in GPX.

following5 added a commit to following5/gpx-extension-v1 that referenced this issue Sep 22, 2017
following5 added a commit to following5/gpx-extension-v1 that referenced this issue Sep 22, 2017
@following5
Copy link
Contributor Author

Just verified via okapi/devel/attrlist that that there are no more than the above two special OC log types.

@following5
Copy link
Contributor Author

Damn... I missed the OCPL "Moved" log type. This is important.

@following5 following5 reopened this Oct 2, 2017
@following5
Copy link
Contributor Author

following5 commented Oct 2, 2017

Uh... this is another complicated issue. There are differences in what is a log type and what a gerneral log property in OCPL, OCDE and Okapi. This applies to the maintenance flags/types as well to moved/log-coordinates. And can we use groundspeak:log_wpt for the coords?

This will need time to sort it out. I would rather postpone that.

@following5
Copy link
Contributor Author

following5 commented Oct 2, 2017

Both OKAPI and OCPL code put the OCPL log types ("Moved" and "OC Team Comment") into groundspeak:type! Noone complained about that, so all the GPX parsers out there can handle this. GSAK treats them as "Comment" logs. I guess all the other do the same.

So the only thing missing is the OCDE "Locked" type. We cannot put this in groundspeak:type, because it maps to GS "Archive".

@andrixnet
Copy link

  • I would make equivalent groundspeak:type entries for each log type that is 1<->1 equivalent
  • I would make closest meaningful match of groundspeak:type for those that are not equivalent
  • I would add oc:logtype for each log type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants