Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ImmediateOrCancel tx fail if zero coins are exchanged #34

Open
gitmalong opened this issue May 6, 2023 · 0 comments
Open

Make ImmediateOrCancel tx fail if zero coins are exchanged #34

gitmalong opened this issue May 6, 2023 · 0 comments

Comments

@gitmalong
Copy link

I noticed that there are ImmediateOrCancel orders that do not make the transaction fail if zero coins are exchanged which is unexpected behavior as IoC orders that do not meet the desired exchange rate threshold lead to failed transactions. As a zero exchange trade does not meet the desired exchange rate as well it should also make the transaction fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gitmalong