[WIP] Add symlink parameter #468
Conversation
…r improved symlink handling
src/main.rs
Outdated
| /// The WeaverArgs will be shared across all commands. So only the general options should be | ||
| /// included here. | ||
| #[derive(Args, Debug)] | ||
| pub struct WeaverArgs { |
There was a problem hiding this comment.
I suggest renaming this struct to CommonRegistryArgs and moving it to src/registry/mod.rs, as it will encapsulate the common arguments for all the registry subcommands. For global arguments (e.g., --debug), Clap already provides a mechanism. However, that mechanism cannot be used here because --follow-symlinks does not apply to commands unrelated to the registry.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
=======================================
- Coverage 72.5% 72.5% -0.1%
=======================================
Files 49 49
Lines 3635 3634 -1
=======================================
- Hits 2639 2637 -2
- Misses 996 997 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…e imports across the registry modules
|
I have fixed the changes you mentioned above and I manually tested the command with a symbolic link folder, and it worked flawlessly. Please let me know if there are any other major changes needed; otherwise, I’ll proceed with writing the tests! @lquerel |
@Leo6Leo Sounds good. Let me know when you are ready for the next review. Thanks |
fixes #441
Summary of the change I have made:
Added an option to follow symbolic links when loading the registry in various parts of the codebase. The primary change is the addition of a
follow_symlinksparameter, which is passed through multiple functions and structures to control this behavior.Key changes include:
follow_symlinksparam asWeaverArgacrossSchemaResolver,SnippetGenerator, andResolvedSemconvRegistryto enable optional symbolic link following during registry operations.-The
WeaverArgsstruct impacted various commands (check,generate,resolve,update-markdown,stats) to include and handle thefollow_symlinksoption.SchemaResolverto configurewalkdir::WalkDirwith thefollow_symlinksparameter and use thefollow_links function.follow_symlinks= false.The ideal outcome would be:
After running the command
weaver will read symbolic linked folders under
sementic-conventions/modeland generate the artifacts.PS: I try to raise this PR first to get some early feedback. As I am new to Rust and Otel, I am open to suggestions and feedback.