Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for semconv and template authors #385

Open
lquerel opened this issue Sep 23, 2024 · 4 comments
Open

Improve documentation for semconv and template authors #385

lquerel opened this issue Sep 23, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@lquerel
Copy link
Contributor

lquerel commented Sep 23, 2024

Describe in detail each Jinja2 filter, function, and test (both those defined in Minijinja and in Weaver).

We could also create an mdBook that we will progressively update to include not only Jinja2-related documentation but also configuration files, JQ filters, Rego-based policies, and more.

@lquerel lquerel added the good first issue Good for newcomers label Sep 23, 2024
@lquerel lquerel changed the title Improve documentation for template authors Improve documentation for semconv and template authors Sep 23, 2024
@Victorsesan
Copy link

Can you assign this to me? I would like to give it a try

@lquerel
Copy link
Contributor Author

lquerel commented Oct 4, 2024

@Victorsesan done. Thank you!

@Victorsesan
Copy link

@lquerel Is there an alternative documentation tool we can use other than mdBook? I'm currently having some trouble setting up the latest version of rust on my console. Also is there any good reference you can direct me to on how you want the documentations to look like . thanks

@lquerel
Copy link
Contributor Author

lquerel commented Oct 8, 2024

@Victorsesan If mdBook doesn’t work for you, we can continue with simple markdown pages like we’ve done so far. That’s perfectly fine. Regarding the documentation and its format, I think the most urgent thing at the moment is to better document the custom filters, functions, and tests supported by the template engine (MiniJinja). The current documentation provides a list but doesn’t show the supported arguments or provide usage examples.

For each filter/function/test, we could have:

  • The Filter/Function/Test name
  • A description
  • A list of arguments (if there are any)
  • The expected result
  • An example of usage

The source code present in this directory will answer most of the above points.

Regarding the examples, the best is probably to look at the existing templates implemented by the various client SDK (see the list here) and to some extent the unit tests in the directory previously mentioned before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants