Check group id, metric name, and group name uniqueness #382
+1,237
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lquerel I think this is unblocked now if you can update the branch |
# Conflicts: # CHANGELOG.md # crates/weaver_resolver/data/registry-test-4-events/expected-registry.json # crates/weaver_resolver/data/registry-test-4-events/registry/mobile-events.yaml
…atest Rust toolchain
…tion severity warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
+ Coverage 72.5% 73.0% +0.4%
=======================================
Files 49 49
Lines 3635 3711 +76
=======================================
+ Hits 2639 2710 +71
- Misses 996 1001 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jsuereth
approved these changes
Nov 21, 2024
| for (key, provenances) in keys { | ||
| if provenances.len() > 1 { | ||
| // Deduplicate the provenances. | ||
| let provenances: HashSet<String> = provenances.into_iter().collect(); |
There was a problem hiding this comment.
Nit: You can use itertools to .unique this when collector instead of forcing a hashset.
I think performance wise it's the same, just easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects duplications in the following semconv concepts:
Since there are existing duplications in the current registries (see the example below), we return warnings instead of errors. As usual, the
--futureflag must be used for future versions of the registry.Example: https://github.com/search?q=repo%3Aopen-telemetry%2Fsemantic-conventions+path%3A%2F%5Emodel%5C%2F%2F+feature_flag&type=code
For now, the group name duplication detection is disabled.
Closes #306