Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check group id, metric name, and event name uniqueness #306

Closed
lmolkova opened this issue Aug 5, 2024 · 1 comment · Fixed by #382
Closed

Check group id, metric name, and event name uniqueness #306

lmolkova opened this issue Aug 5, 2024 · 1 comment · Fixed by #382
Assignees
@lquerel
Labels
enhancement New feature or request

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Aug 5, 2024 •
edited
Loading

We need to check that metric/events names are unique similarly to open-telemetry/semantic-conventions#1302

Also that group-ids are unique

Blocking PRs in semconv:
@lmolkova lmolkova added the enhancement New feature or request label Aug 5, 2024
@lmolkova lmolkova changed the title Check metric name and event name uniqueness Check, group id, metric name, and event name uniqueness Aug 8, 2024
@lmolkova lmolkova mentioned this issue Aug 8, 2024
Merged
3 tasks
@lmolkova lmolkova changed the title Check, group id, metric name, and event name uniqueness Check group id, metric name, and event name uniqueness Aug 8, 2024
@lmolkova lmolkova transferred this issue from open-telemetry/semantic-conventions Aug 9, 2024
@lquerel lquerel mentioned this issue Sep 20, 2024
Merged
@lmolkova
Copy link
Contributor Author

Blocked on open-telemetry/semantic-conventions#1423

@lmolkova lmolkova mentioned this issue Oct 23, 2024
Merged
@github-project-automation github-project-automation bot moved this from Next Release to Done in OTel Weaver Project Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lquerel lquerel

Labels
enhancement New feature or request
Projects
OTel Weaver Project
Status: Done
Semantic Conventions Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check group id, metric name, and group name uniqueness lquerel/otel-weaver
3 participants
@lquerel @lmolkova @joaopgrassi