Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images not qualified, leading to errors when running make check-policies #1571

Open
michaelsafyan opened this issue Nov 12, 2024 · 0 comments
Labels
area:other bug Something isn't working tooling Regarding build, workflows, build-tools, ... triage:needs-triage

Comments

@michaelsafyan
Copy link
Contributor

Area(s)

area:other

What happened?

Description

Docker containers used in Makefile are not qualified leading to errors:

[~/Code/github/michaelsafyan/open-telemetry.semantic-conventions (refattr)]$ make check-policies
docker run --rm \
        --mount 'type=bind,source=/home/michaelsafyan/Code/github/michaelsafyan/open-telemetry.semantic-conventions/policies,target=/home/weaver/policies,readonly' \
        --mount 'type=bind,source=//home/michaelsafyan/Code/github/michaelsafyan/open-telemetry.semantic-conventions/model,target=/home/weaver/source,readonly' \
        otel/weaver:v0.10.0 registry check \
        --registry=/home/weaver/source \
        --baseline-registry=https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.28.0.zip[model] \
        --policy=/home/weaver/policies
Error: short-name "otel/weaver:v0.10.0" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"
make: *** [Makefile:249: check-policies] Error 125

Steps to Reproduce (if any)

  1. Install podman-is-docker so that the docker command becomes an alias over podman
  2. Run make check-policies inside the repo

Expected Result

Should work

Actual Result

Fails, because top-level dependencies.Dockerfile does not qualify the dependencies

Semantic convention version

3c95994

Additional context

No response

@michaelsafyan michaelsafyan added bug Something isn't working triage:needs-triage labels Nov 12, 2024
@arminru arminru added the tooling Regarding build, workflows, build-tools, ... label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:other bug Something isn't working tooling Regarding build, workflows, build-tools, ... triage:needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants