Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should be able to check if changes in generate_workflows_lib affects core #2965

Open
xrmx opened this issue Nov 6, 2024 · 2 comments
Open
Labels
bug Something isn't working build & infra

Comments

@xrmx
Copy link
Contributor

xrmx commented Nov 6, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
Package version: (e.g., 0.46.0)

What happened?

I changed generate_workflows_lib here and tests were green, unfortunately it broke core because the new behaviour does not fit what core is doing. If we change .github/workflows/generate_workflows_lib we should probably run a new job that is checking out core and testing that the generation is not different than what was before. We can use the skip-generate-workflows to ignore any error if really we want a behavior change

Additional context

No response

Would you like to implement a fix?

None

@xrmx xrmx added the bug Something isn't working label Nov 6, 2024
@lzchen
Copy link
Contributor

lzchen commented Nov 8, 2024

Alternatively, maybe we can have another copy of generate_workflows.py on core to generate the core specific workflows so we reduce the dependency on contrib (although we would still need it for the contrib.yml workflow but at least it reduces the conflicts).

@xrmx
Copy link
Contributor Author

xrmx commented Nov 13, 2024

In november 13th meeting we decided to pursue other changes before looking at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build & infra
Projects
None yet
Development

No branches or pull requests

3 participants