[sdk-node] automatically configure metrics exporter based on enviornment variables #4551

pichlermarc · 2024-03-18T09:27:46Z

Currently, we don't auto-configure a MetricReader/exporter combination when using the @opentelemetry/sdk-node package.
Goal of this issue is to implement exporter selection for metrics based on this specification:

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#exporter-selection

For this issue to be considered done we need to implement the following behavior:

If no metric reader is configured by the user:

use OTEL_METRICS_EXPORTER environment variable to determine an exporter and add it to the MeterProvider that's created by NodeSDK
- pair it up with a PeriodicExportingMetricReader if it is a PushMetricExporter
- see https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#exporter-selection
- for now, do NOT set up a MeterProvider if OTEL_METRICS_EXPORTER is unset, any current code-only configuration should continue to work as it does now. If a metricReader is already provided by the user, do NOT override or add an additional reader based on the contents of OTEL_METRICS_EXPORTER
use the OTEL_EXPORTER_OTLP_METRICS_PROTOCOL to determine the OTLP exporter to use (http/json, http/protobuf, grpc)
- see https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#specify-protocol
use the OTEL_EXPORTER_OTLP_PROTOCOL env var as a fallback to the above to determine the OTLP exporter to use (http/json, http/protobuf, grpc)
fallback to using http/protobuf if none of the two protocol env vars are set

The text was updated successfully, but these errors were encountered:

Prashansa-K · 2024-05-06T07:27:58Z

@pichlermarc I would like to work on this. I have used this package in the past.

pichlermarc · 2024-05-06T08:53:47Z

@Prashansa-K thanks for picking this up. It's yours 🙂

Prashansa-K · 2024-05-07T07:02:31Z

@pichlermarc
I have some doubts here.

In first action item from the description mentions "use OTEL_METRICS_EXPORTER environment variable to determine an exporter and add it to the MeterProvider that's created by NodeSDK",
However, as I see the code, addMetricReader() method is deprecated and would be removed in v2. It is suggests to use the MeterProvider constructor here.
So, should we keep creating new MeterProvider objects here based on the exporters provided via env variable?
I am assuming that we can provide >1 metric exporters via env configurations, just like trace exporters. Is that correct? I couldn't find a clarification for this in the specification document.

pichlermarc · 2024-05-07T10:25:47Z

So, should we keep creating new MeterProvider objects here based on the exporters provided via env variable?

If the env var is set, only create a single MeterProvider and add all MetricReaders to that MeterProvider via the constructor option (it's an array). That means that creation of the exporters with auto-paired MetricReaders has to happen before instantiating a MeterProvider.

I am assuming that we can provide >1 metric exporters via env configurations, just like trace exporters. Is that correct? I couldn't find a clarification for this in the specification document.

That's correct. 🙂 The specification reads:

The implementation MAY accept a comma-separated list to enable setting multiple exporters.

so that's applicable to all exporter selection env vars.

bhaskarbanerjee · 2024-06-11T16:27:58Z

@pichlermarc is this behavior consistent across python,java, go etc?

bhaskarbanerjee · 2024-06-13T00:02:33Z

@pichlermarc would it be possible to have some answers on the above question? I am trying to understand if this by design for all nodejs layer.sdk or all other languages too?

pichlermarc · 2024-06-13T11:11:01Z

@pichlermarc is this behavior consistent across python,java, go etc?
would it be possible to have some answers on the above question? I am trying to understand if this by design for all nodejs layer.sdk or all other languages too?

I'm not sure what the question is here - the feature is not implemented yet. As with all specification features, the behavior aims to be aligned across all languages.

bhaskarbanerjee · 2024-06-13T13:02:37Z

@pichlermarc what I mean to understand is whether python, go, java export metrics by deafult or do they not just like in nodejs. same goes for logs.

bhaskarbanerjee · 2024-06-13T21:53:30Z

@pichlermarc if you could please help me get answer on my above question?
@Prashansa-K how far is the PR that you are working on?

silpamittapalli · 2024-06-13T22:08:20Z

Hi there @pichlermarc
Following up on Bhaskar's comment above. Is the MetricReader/exporter combination not auto-configured when using @opentelemetry/sdk-node package only? or Is this behavior expected with other language SDKs too? Please clarify.

If this choice was made by design, we would love to understand the reasoning behind this choice.

To expedite progress, we would be happy to claim and/or contribute to this feature if needed. Please let us know @Prashansa-K

pichlermarc · 2024-06-14T10:44:08Z

Following up on Bhaskar's comment above. Is the MetricReader/exporter combination not auto-configured when using @opentelemetry/sdk-node package only? or Is this behavior expected with other language SDKs too? Please clarify.

I don't know the exact state of all the other language SDKs autoconfigure packages. I know that the specification does not prescribe a default. Posting research here would be very welcome 🙂

If this choice was made by design, we would love to understand the reasoning behind this choice.

It was a conscious decision. As there was no way to set up the metrics exporter, automatically setting up the MeterProvider for it would've been more annoying than helpful until this feature here and #4655 are implemented.

I updated the issue description to reflect that. When implementing this feature do NOT set up a MeterProvider if the OTEL_METRICS_EXPORTER env var is not set. We can revisit that decision when #4655 is implemented.

bhaskarbanerjee · 2024-06-14T13:41:09Z

Thanks @pichlermarc for the clarification. As we dig more, shall share the findings here.

bhaskarbanerjee · 2024-06-14T13:43:26Z

@Prashansa-K please help us understand how far the PR is. We have needs in this area and are happy to pair up, if that can expedite your contribution.

bhaskarbanerjee · 2024-06-17T14:25:18Z

@pichlermarc Is there anything we can do to expedite this?
We are also very willing to cut out a PR for this, if other contributors are busy. Please advice.

pichlermarc · 2024-06-17T15:14:22Z

@bhaskarbanerjee I don't have any way to reach out to @Prashansa-K, unfortunately.

Looks like there's no response to the above comment and the issue was assigned a little over a month ago.
@bhaskarbanerjee I'd appreciate you opening a PR to implement this feature.

bhaskarbanerjee · 2024-06-17T16:32:13Z

Thanks for prompt response @pichlermarc we will get on top of this. cc @silpamittapalli

haythemtrabelsi117 · 2024-09-20T11:48:29Z

hi, what's the status on this?

bhaskarbanerjee · 2024-10-02T15:58:35Z

@haythemtrabelsi117 we got delayed but are now actively working on this. Please expect a PR by end of this month.

bhaskarbanerjee · 2024-10-02T18:48:38Z

@pichlermarc @dyladan
I need to make updates to opentelemetry-js/opentelemetry-core (add another supported env var named OTEL_METRICS_EXPORTER) before I can make other updates to the opentelemetry-js/opentelemetry-sdk-node. should I raise 2 separate PRs?

bhaskarbanerjee · 2024-10-02T18:49:09Z

@pichlermarc can you please assign this ticket to me?

pichlermarc · 2024-10-03T07:42:03Z

@bhaskarbanerjee please don't access the core module anymore to get the environment config, we're moving away from that. You can directly use process.env.OTEL_METRICS_EXPORTER and parse that input, then you can do it in the same PR. 🙂

bhaskarbanerjee · 2024-10-03T08:31:16Z

Thanks for that info @pichlermarc , will follow that.

bhaskarbanerjee · 2024-10-22T17:12:19Z

@pichlermarc I am in process of drafting this PR. I see there is a function for configuring the log provider from env.

The simplest way to solve this would be to add a similar function for configuring the metric provider and then write tests on top of this.

Are you good with approach or do you have another suggestion?

private configureMetricProviderFromEnv(): void {
    const metricsExporterList = process.env.OTEL_METRICS_EXPORTER ?? '';
    const enabledExporters = filterBlanksAndNulls(metricsExporterList.split(','));
    if (enabledExporters.length === 0) {
      diag.info('OTEL_METRICS_EXPORTER is empty. Using default otlp exporter.');
      enabledExporters.push('otlp');
    }

    if (enabledExporters.includes('none')) {
      diag.info(
        `OTEL_METRICS_EXPORTER contains "none". Metric provider will not be initialized.`
      );
      return;
    }

    enabledExporters.forEach(exporter => {
      if (exporter === 'otlp') {
        const protocol = (
          process.env.OTEL_EXPORTER_OTLP_METRIC_PROTOCOL ??
          process.env.OTEL_EXPORTER_OTLP_PROTOCOL
        )?.trim();

        switch (protocol) {
          case 'grpc':
            exporters.push(new OTLPGrpcMetricExporter());
            break;
          case 'http/json':
            exporters.push(new OTLPHttpMetricExporter());
            break;
          case 'http/protobuf':
            exporters.push(new OTLPProtoMetricExporter());
            break;
          case undefined:
          case '':
            exporters.push(new OTLPProtoMetricExporter());
            break;
          default:
            diag.warn(
              `Unsupported OTLP metrics protocol: "${protocol}". Using http/protobuf.`
            );
            exporters.push(new OTLPProtoMetricExporter());
        }
      } else if (exporter === 'console') {
        exporters.push(new ConsoleMetricExporter());
      } else if (exporter === 'prometheus') {
        exporters.push(new PrometheusMetricExporter());
      } else {
        diag.warn(
          `Unsupported OTEL_METRICS_EXPORTER value: "${exporter}". Supported values are: otlp, console, prometheus, none.`
        );
      }
    });

    if (exporters.length > 0) {
      exporters.map(exporter => {
          if (exporter instanceof PrometheusMetricExporter) {
            // return a PullBasedReader
            return;
          } else {
            const exportIntervalMillis = process.env.OTEL_METRICS_EXPORTER_INTERVAL ?? 500
            return new PeriodicExportingMetricReader({
              exporter: exporter,
              exportIntervalMillis: exportIntervalMillis
            });
          }
        })
    }
  }

And then add the below lines to end of https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-sdk-node/src/sdk.ts#L212

  else {
      this._meterProviderConfig.reader = this.configureMetricProviderFromEnv()
    }

bhaskarbanerjee · 2024-10-22T17:42:10Z

@pichlermarc one more testing question. Apart from Unit testing, what other testing is encouraged and is there a designated process to do so?

bhaskarbanerjee · 2024-10-23T11:00:28Z

@pichlermarc any thoughts on the above?

pichlermarc · 2024-10-24T08:45:24Z

@bhaskarbanerjee yes that sounds good - some suggestion for the code above: you may want to immediately pair the exporter with a PeriodiceExportingMetricReader where applicable - this way you can hold MetricReader instances and you can drop the instanceof check for the prometheus exporter. Other than that this looks good.

@pichlermarc one more testing question. Apart from Unit testing, what other testing is encouraged and is there a designated process to do so?

There's only "unit"-tests in @opentelemetry/sdk-node - if you add tests for the functionality you're adding then that's sufficient. You can check the existing tests - I think similar ones should suffice. FYI: the quality of tests in @opentelemetry/sdk-node is not the best at the moment (they're asserting on lots of internal state of other packages, etc) - if you can come up with higher-quality ones instead of following what's already there, I'd appreciate it. 🙂

bhaskarbanerjee · 2024-10-25T06:26:26Z

🆒 Thanks @pichlermarc My PR should be therein a few days. I will try my best with the unit tests.
The current unit tests are failing on other packages. Is there a way to run only the tests for sdk-node package?

 --------------------|---------|----------|---------|---------|--------------------------------------
       File                | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                    
       --------------------|---------|----------|---------|---------|--------------------------------------
       All files           |   89.66 |    82.43 |   98.01 |   89.68 |                                      
        src                |    89.6 |    82.36 |      98 |   89.61 |                                      
         http.ts           |   90.42 |    87.38 |   97.26 |   91.07 | ...,722-734,775,833,839,964-966,1011 
         utils.ts          |   88.92 |    78.59 |     100 |   88.32 | ...0,636-650,670-672,681,750,924,932 
        src/enums          |     100 |      100 |     100 |     100 |                                      
         AttributeNames.ts |     100 |      100 |     100 |     100 |                                      
       --------------------|---------|----------|---------|---------|--------------------------------------
       npm ERR! Lifecycle script `test:cjs` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http 
       npm ERR! Lifecycle script `test` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http 
       

    ✖  @opentelemetry/exporter-logs-otlp-proto:test
       > @opentelemetry/[email protected] test
       > nyc mocha 'test/**/*.test.ts' --exclude 'test/browser/**/*.ts'
       
       
        Exception during run: src/platform/node/OTLPLogExporter.ts(27,25): error TS2307: Cannot find module '../../version' or its corresponding type declarations.
       
       ----------|---------|----------|---------|---------|-------------------
       File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
       ----------|---------|----------|---------|---------|-------------------
       All files |       0 |        0 |       0 |       0 |                   
       ----------|---------|----------|---------|---------|-------------------
       npm ERR! Lifecycle script `test` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/exporter-logs-otlp-proto 
       

    ✖  @opentelemetry/exporter-logs-otlp-http:test
       > @opentelemetry/[email protected] test
       > nyc mocha 'test/**/*.test.ts' --exclude 'test/browser/**/*.ts'
       
       
        Exception during run: test/node/OTLPLogExporter.test.ts(33,25): error TS2307: Cannot find module '../../src/version' or its corresponding type declarations.
       
       ----------|---------|----------|---------|---------|-------------------
       File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
       ----------|---------|----------|---------|---------|-------------------
       All files |       0 |        0 |       0 |       0 |                   
       ----------|---------|----------|---------|---------|-------------------
       npm ERR! Lifecycle script `test` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/exporter-logs-otlp-http 
       
    ✔  @opentelemetry/instrumentation-grpc:test (15s)

    ✖  @opentelemetry/exporter-metrics-otlp-http:test
       > @opentelemetry/[email protected] test
       > nyc mocha 'test/**/*.test.ts' --exclude 'test/browser/**/*.ts'
       
       
        Exception during run: src/platform/node/OTLPMetricExporter.ts(28,25): error TS2307: Cannot find module '../../version' or its corresponding type declarations.
       
       ----------|---------|----------|---------|---------|-------------------
       File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
       ----------|---------|----------|---------|---------|-------------------
       All files |       0 |        0 |       0 |       0 |                   
       ----------|---------|----------|---------|---------|-------------------
       npm ERR! Lifecycle script `test` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/opentelemetry-exporter-metrics-otlp-http 
       

    ✖  @opentelemetry/exporter-trace-otlp-http:test
       > @opentelemetry/[email protected] test
       > nyc mocha 'test/**/*.test.ts' --exclude 'test/browser/**/*.ts'
       
       
        Exception during run: src/platform/node/OTLPTraceExporter.ts(21,25): error TS2307: Cannot find module '../../version' or its corresponding type declarations.
       
       ----------|---------|----------|---------|---------|-------------------
       File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
       ----------|---------|----------|---------|---------|-------------------
       All files |       0 |        0 |       0 |       0 |                   
       ----------|---------|----------|---------|---------|-------------------
       npm ERR! Lifecycle script `test` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/exporter-trace-otlp-http 
       

    ✖  @opentelemetry/exporter-trace-otlp-proto:test
       > @opentelemetry/[email protected] test
       > nyc mocha 'test/**/*.test.ts' --exclude 'test/browser/**/*.ts'
       
       
        Exception during run: test/node/OTLPTraceExporter.test.ts(39,25): error TS2307: Cannot find module '../../src/version' or its corresponding type declarations.
       
       ----------|---------|----------|---------|---------|-------------------
       File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
       ----------|---------|----------|---------|---------|-------------------
       All files |       0 |        0 |       0 |       0 |                   
       ----------|---------|----------|---------|---------|-------------------
       npm ERR! Lifecycle script `test` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/exporter-trace-otlp-proto 
       

    ✖  @opentelemetry/otlp-grpc-exporter-base:test
       > @opentelemetry/[email protected] test
       > nyc mocha 'test/**/*.test.ts'
       
       
        Exception during run: test/configuration/otlp-grpc-configuration.test.ts(29,25): error TS2307: Cannot find module '../../src/version' or its corresponding type declarations.
       
       ----------|---------|----------|---------|---------|-------------------
       File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
       ----------|---------|----------|---------|---------|-------------------
       All files |       0 |        0 |       0 |       0 |                   
       ----------|---------|----------|---------|---------|-------------------
       npm ERR! Lifecycle script `test` failed with error: 
       npm ERR! Error: command failed 
       npm ERR!   in workspace: @opentelemetry/[email protected] 
       npm ERR!   at location: /Users/hkn097/workspace-git/OpenSource/opentelemetry-js/experimental/packages/otlp-grpc-exporter-base 
       

 ———————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  Lerna (powered by Nx)   Ran target test for 40 projects (1m)
 
    ✔    28/35 succeeded [0 read from cache]
 
    ✖    7/35 targets failed, including the following:
         - @opentelemetry/instrumentation-http:test
         - @opentelemetry/exporter-logs-otlp-proto:test
         - @opentelemetry/exporter-logs-otlp-http:test
         - @opentelemetry/exporter-metrics-otlp-http:test
         - @opentelemetry/exporter-trace-otlp-http:test
         ...and 2 more...
 
   Hint: Try "nx view-logs" to get structured, searchable errors logs in your browser.
 
sh-3.2$ npm -v
10.5.0
sh-3.2$ node -v
v20.12.0
sh-3.2$ npx lerna run test

pichlermarc · 2024-10-25T15:02:37Z

@bhaskarbanerjee please read https://github.com/open-telemetry/opentelemetry-js/blob/be1737fc46c1c0fbe75f4d30ce5a196ebeee4c09/CONTRIBUTING.md#development-quick-start and follow the steps there - the steps that are listed there are necessary to setup auto-generated files that are required to make tests pass.

After doing that once you can just run npm run test in ./experimental/opentelemetry-sdk-node/ and it'll just run the tests for that package.

bhaskarbanerjee · 2024-10-25T17:42:35Z

Thanks @pichlermarc I will check this out

pichlermarc added up-for-grabs Good for taking. Extra help will be provided by maintainers triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address needs:code-contribution This feature/bug is ready to implement labels Mar 18, 2024

pichlermarc mentioned this issue Mar 18, 2024

[sdk-node] automatically configure exporters based on enviornment variables #3871

Open

pichlermarc added the pkg:sdk-node label Mar 18, 2024

pichlermarc mentioned this issue Mar 18, 2024

NodeJS auto instrumentation does not generate metrics (docs/languages/js/automatic) open-telemetry/opentelemetry.io#4171

Closed

david-luna mentioned this issue Apr 12, 2024

Auto-Instrumentation and Metrics #4607

Closed

pichlermarc mentioned this issue Apr 23, 2024

[sdk-node] implement enviornment configuration for auto-paired PeriodicExportingMetricReader #4655

Open

2 tasks

pichlermarc assigned Prashansa-K May 6, 2024

pichlermarc removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label May 6, 2024

pichlermarc assigned bhaskarbanerjee and unassigned Prashansa-K Oct 3, 2024

pichlermarc mentioned this issue Nov 13, 2024

Configure OTLP metrics exporter with environment variables #3193

Open

bhaskarbanerjee linked a pull request Nov 15, 2024 that will close this issue

feat(opentelemetry-sdk-node): automatically configure metrics exporter based on environment variables #5168

Open

8 tasks

JamieDanielson mentioned this issue Nov 19, 2024

Add metrics support to auto-instrumentations-node open-telemetry/opentelemetry-js-contrib#2527

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sdk-node] automatically configure metrics exporter based on enviornment variables #4551

[sdk-node] automatically configure metrics exporter based on enviornment variables #4551

pichlermarc commented Mar 18, 2024 •

edited

Loading

Prashansa-K commented May 6, 2024

pichlermarc commented May 6, 2024

Prashansa-K commented May 7, 2024 •

edited

Loading

pichlermarc commented May 7, 2024

bhaskarbanerjee commented Jun 11, 2024

bhaskarbanerjee commented Jun 13, 2024

pichlermarc commented Jun 13, 2024

bhaskarbanerjee commented Jun 13, 2024

bhaskarbanerjee commented Jun 13, 2024

silpamittapalli commented Jun 13, 2024

pichlermarc commented Jun 14, 2024 •

edited

Loading

bhaskarbanerjee commented Jun 14, 2024

bhaskarbanerjee commented Jun 14, 2024

bhaskarbanerjee commented Jun 17, 2024

pichlermarc commented Jun 17, 2024

bhaskarbanerjee commented Jun 17, 2024

haythemtrabelsi117 commented Sep 20, 2024

bhaskarbanerjee commented Oct 2, 2024

bhaskarbanerjee commented Oct 2, 2024

bhaskarbanerjee commented Oct 2, 2024

pichlermarc commented Oct 3, 2024

bhaskarbanerjee commented Oct 3, 2024

bhaskarbanerjee commented Oct 22, 2024

bhaskarbanerjee commented Oct 22, 2024

bhaskarbanerjee commented Oct 23, 2024

pichlermarc commented Oct 24, 2024

bhaskarbanerjee commented Oct 25, 2024

pichlermarc commented Oct 25, 2024

bhaskarbanerjee commented Oct 25, 2024

[sdk-node] automatically configure metrics exporter based on enviornment variables #4551

[sdk-node] automatically configure metrics exporter based on enviornment variables #4551

Comments

pichlermarc commented Mar 18, 2024 • edited Loading

Prashansa-K commented May 6, 2024

pichlermarc commented May 6, 2024

Prashansa-K commented May 7, 2024 • edited Loading

pichlermarc commented May 7, 2024

bhaskarbanerjee commented Jun 11, 2024

bhaskarbanerjee commented Jun 13, 2024

pichlermarc commented Jun 13, 2024

bhaskarbanerjee commented Jun 13, 2024

bhaskarbanerjee commented Jun 13, 2024

silpamittapalli commented Jun 13, 2024

pichlermarc commented Jun 14, 2024 • edited Loading

bhaskarbanerjee commented Jun 14, 2024

bhaskarbanerjee commented Jun 14, 2024

bhaskarbanerjee commented Jun 17, 2024

pichlermarc commented Jun 17, 2024

bhaskarbanerjee commented Jun 17, 2024

haythemtrabelsi117 commented Sep 20, 2024

bhaskarbanerjee commented Oct 2, 2024

bhaskarbanerjee commented Oct 2, 2024

bhaskarbanerjee commented Oct 2, 2024

pichlermarc commented Oct 3, 2024

bhaskarbanerjee commented Oct 3, 2024

bhaskarbanerjee commented Oct 22, 2024

bhaskarbanerjee commented Oct 22, 2024

bhaskarbanerjee commented Oct 23, 2024

pichlermarc commented Oct 24, 2024

bhaskarbanerjee commented Oct 25, 2024

pichlermarc commented Oct 25, 2024

bhaskarbanerjee commented Oct 25, 2024

pichlermarc commented Mar 18, 2024 •

edited

Loading

Prashansa-K commented May 7, 2024 •

edited

Loading

pichlermarc commented Jun 14, 2024 •

edited

Loading