Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-trace-base] remove _registeredSpanProcessors private property #5136

Open
david-luna opened this issue Nov 11, 2024 · 1 comment
Open

[sdk-trace-base] remove _registeredSpanProcessors private property #5136

david-luna opened this issue Nov 11, 2024 · 1 comment
Labels
needs:code-contribution This feature/bug is ready to implement never-stale pkg:sdk-node pkg:sdk-trace-base target:next-major-release This PR targets the next major release (`next` branch)

Comments

@david-luna
Copy link
Contributor

david-luna commented Nov 11, 2024 •
edited by pichlermarc
Loading

Important

Only actionable for next branch. Any PRs opened for this MUST be based on and targeted at the next branch.

As a result of removing the BasicTracerProvider.addSpanProcessor API there is no reason to keep a private property keeping a reference to the Span processors added via constructor. This removal will occur when #5152 is merged

Checklist:

Ref conversation
@david-luna david-luna added never-stale pkg:sdk-node pkg:sdk-trace-base target:next-major-release This PR targets the next major release (`next` branch) labels Nov 11, 2024
@pichlermarc pichlermarc added the blocked Currently blocked on another item label Nov 11, 2024
@pichlermarc pichlermarc mentioned this issue Nov 12, 2024
Closed
4 tasks
@pichlermarc pichlermarc removed the blocked Currently blocked on another item label Nov 15, 2024
@pichlermarc
Copy link
Member

@david-luna I updated the description and removed the blocked label as #5152 has merged 🙂

@pichlermarc pichlermarc added the needs:code-contribution This feature/bug is ready to implement label Nov 15, 2024
@david-luna david-luna mentioned this issue Nov 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:code-contribution This feature/bug is ready to implement never-stale pkg:sdk-node pkg:sdk-trace-base target:next-major-release This PR targets the next major release (`next` branch)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@david-luna @pichlermarc