Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Span Attributes: http.url must not contain username / password #2000

Open
pellared opened this issue Mar 9, 2021 · 11 comments · May be fixed by #5038
Open

HTTP Span Attributes: http.url must not contain username / password #2000

pellared opened this issue Mar 9, 2021 · 11 comments · May be fixed by #5038
Assignees
@GeorgeSaussy @shoppingjaws
Labels
bug Something isn't working contribfest These small and isolated issues are suitable for Kubecon Contribfest good first issue Good for newcomers never-stale priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug

Comments

@pellared
Copy link
Member

pellared commented Mar 9, 2021

As is stated in the recent specification change :

http.url MUST NOT contain credentials passed via URL in form of https://username:[email protected]/. In such case the attribute's value should be https://www.example.com/
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 15, 2022
@dyladan
Copy link
Member

dyladan commented Aug 15, 2022

we should probably parse using URL and reserialize without username/password

@dyladan dyladan added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers never-stale priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug and removed stale feature-request labels Aug 15, 2022
@daniel-white
Copy link

ill take this!

@daniel-white daniel-white mentioned this issue Dec 14, 2022
Closed
7 tasks
@legendecas legendecas removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 15, 2022
@clesleycode
Copy link

@daniel-white Are you still working on this?

@mannyistyping
Copy link

@clesleycode 👋🏽 It's been a bit and I wonder if it'd make sense at this point to reassign?

What are your thoughts on this @legendecas ?
What is the common wait time for reassigning a possibly abandoned issue?

@legendecas
Copy link
Member

@mannyistyping you can definitely take the task if you are ready to work on it!

My opinion is still the same as #3487 (comment).

@dyladan dyladan added the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Nov 8, 2023
@GeorgeSaussy
Copy link

I'd like to work on this.

@shoppingjaws shoppingjaws mentioned this issue Jan 6, 2024
Closed
7 tasks
@shoppingjaws
Copy link

@GeorgeSaussy
This PR seems to have stopped, and I would like to take on the challenge as Otel's First Commit, but could you please give it to me?

@shoppingjaws
Copy link

@pkanal
Hi I want to work on this issue, what should I do?

@dyladan dyladan added the bug Something isn't working label Jan 24, 2024
@create2000
Copy link

@dyladan My name is Anthony Onah. I am an outreach intern for December 24. I'd like to contribute to this as my first contribution. Can it be assigned to me? Also, do i need to fork the whole repo in order to work on it? cos i have been trying to run it on my local machine but getting some errors which i do not know could be opened as an issue.

@Victorsesan
Copy link

Hi @dyladan i will like to work on this issue

@Dorcas-BD Dorcas-BD linked a pull request Oct 4, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeSaussy GeorgeSaussy

@shoppingjaws shoppingjaws

Labels
bug Something isn't working contribfest These small and isolated issues are suitable for Kubecon Contribfest good first issue Good for newcomers never-stale priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug
Projects
None yet
Milestone
No milestone
10 participants
@daniel-white @dyladan @pellared @legendecas @clesleycode @GeorgeSaussy @shoppingjaws @mannyistyping @create2000 @Victorsesan