Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis attributes not aligned with latest semantic conventions #12324

Open
luke6Lh43 opened this issue Sep 24, 2024 · 1 comment
Open

Redis attributes not aligned with latest semantic conventions #12324

luke6Lh43 opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something isn't working needs triage New issue that requires triage

Comments

@luke6Lh43
Copy link

Describe the bug

Hello,

I have recently been working on a project that required Redis instrumentation for two different languages. During this process, I noticed some discrepancies in the attributes being collected. To investigate further, I conducted testing to check the attributes collected for Redis instrumentation across six of the most popular languages. I have documented my testing in this GitHub repository:

[Link to GitHub Repo]

Findings for Java:

What We Capture Today ==> How It Should Look in Latest Semantic Conventions

db.operation: GET ==> db.operation.name: GET
network.peer.port: 6379 ==> network.peer.port: 6379
network.type: ipv6 ==> (Not needed)
network.peer.address: 0:0:0:0:0:0:0:1 ==> network.peer.name: 0:0:0:0:0:0:0:1
db.statement: GET mykey ==> db.query.text: GET mykey
db.system: redis ==> db.system: redis
(Not captured) ==> db.namespace: 0

The latest OpenTelemetry semantic conventions for Redis can be found here:
OpenTelemetry Semantic Conventions for Redis

Steps to reproduce

https://github.com/luke6Lh43/otel-redis-testing/blob/main/Readme.md#java

Expected behavior

N/A

Actual behavior

N/A

Javaagent or library instrumentation version

v2.8.0

Environment

OS: macOS Sequoia
Architecture: x86_64 (Intel processor)
JDK: openjdk 22.0.2
Apache Maven 3.9.8

Additional context

No response

@luke6Lh43 luke6Lh43 added bug Something isn't working needs triage New issue that requires triage labels Sep 24, 2024
@trask
Copy link
Member

trask commented Sep 24, 2024

hi @luke6Lh43! check out the warning at the top of https://opentelemetry.io/docs/specs/semconv/database/database-spans/

also check out #11575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New issue that requires triage
Projects
None yet
Development

No branches or pull requests

2 participants