Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple trace context propagation functionality for gRPC into a separate library #11688

Open
nareshz opened this issue Jun 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nareshz
Copy link

nareshz commented Jun 28, 2024

Is your feature request related to a problem? Please describe.

We want to propagate trace context using W3 Trace Context header(traceparent) in gRPC requests made by using Spanner client library.

Currently https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/grpc-1.6/library provides GrpcTelemetry ClientInterceptor which can be used to intercept gRPC calls and add trace context headers in calls. The issue is that this library is in alpha version due to work going on semantic conventions.

We want to avoid adding alpha version library inside Spanner client library for trace context propagation as it may have breaking change in the future and instead use a stable one.

Describe the solution you'd like

Creating a stable library specific to only trace context propagation can solve the issue.

Describe alternatives you've considered

No response

Additional context

No response

@nareshz nareshz added enhancement New feature or request needs triage New issue that requires triage labels Jun 28, 2024
@breedx-splk
Copy link
Contributor

I'm not aware of any precedent for this -- factoring out the context extraction and propagation into its own module. Even if we were to do this, I'm not entirely convinced that it would "stabilize" (go non-alpha) somehow faster than the library instrumentation would. I appreciate that you're wanting to be able to use parts of the instrumentation in the spanner client, though.

@breedx-splk breedx-splk removed the needs triage New issue that requires triage label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants