Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure resource providers #1228

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Azure resource providers #1228

wants to merge 13 commits into from

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Mar 14, 2024 •
edited
Loading

Fixes #1214

Testing:

Has not been tested in a real setup yet - but all implementations are based on the existing resource providers in other languages.

Documentation:

done

Outstanding items

Owner

Need component owners. I can be one of them.

Host image attributes

VM seems to support host.image related attributes

  • host.image.id =
  • host.image.name =
  • host.image.version =

(from https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=linux)

            "imageReference": {
                "id": "",
                "offer": "UbuntuServer",
                "publisher": "Canonical",
                "sku": "16.04.0-LTS",
                "version": "latest",
                "communityGalleryImageId": "/CommunityGalleries/testgallery/Images/1804Gen2/Versions/latest",
                "sharedGalleryImageId": "/SharedGalleries/1P/Images/gen2/Versions/latest",
                "exactVersion": "1.1686127202.30113"
            },

does that make sense?

Stop VM detector fast

Right now, the VM detector has a timeout of 1s - which means that it will block the startup process by 1s if we're not running in an Azure VM. How can we avoid that?

INFO: AzureVmResourceProvider.createResource took 1388 ms

An idea is to look for the /etc/resolv.conf file on linux - and some special registry key on windows.

Is that really the best option?

@zeitlinger zeitlinger requested a review from a team March 14, 2024 14:47
@zeitlinger
Copy link
Member Author

@trask here's my first attempt - can you help with testing?

heyams
heyams reviewed Mar 20, 2024
View reviewed changes
azure-resources/README.md

The following OpenTelemetry semantic conventions will be detected:

| Resource attribute | VM | Functions | App Service | Containers |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add aks (azure Kubernetes service)?

Copy link
Contributor

@heyams heyams Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeitlinger do you think it's a good idea to add AKS?

cloud.provider=Azure
cloud.platform=azure_aks
cloud.resource_id=${armId},
cloud.region=${armRegion},
k8s.cluster.name=
k8s.namespace.name=
k8s.node.name=
k8s.pod.name=
k8s.pod.uid
k8s.container.name

k8s.deployment.name
k8s.deployment.uid

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, definitely. So far, I've started with the existing implementations in other languages.

Can you point me to a starting point to implement an AKS provider?

@SylvainJuge SylvainJuge mentioned this pull request Apr 4, 2024
Open
7 tasks
@heyams heyams mentioned this pull request Apr 18, 2024
Draft
@zeitlinger
Copy link
Member Author

@trask can you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyams heyams heyams left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add resource provider for Azure
2 participants
@zeitlinger @heyams