Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[collector] PrometheusRule is not created when using PodMonitor #1379

Open
lindeskar opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1416
Open

[collector] PrometheusRule is not created when using PodMonitor #1379

lindeskar opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1416
Labels
chart:collector Issue related to opentelemetry-collector helm chart

Comments

@lindeskar
Copy link
Contributor

The condition here:

opentelemetry-helm-charts/charts/opentelemetry-collector/templates/prometheusrule.yaml

Line 1 in 3a6fff3

{{- if and .Values.prometheusRule.enabled .Values.serviceMonitor.enabled }}

means the PrometheusRule resource is not created when using PodMonitor instead of ServiceMonitor (makes sense for mode: daemonset).

Can change the condition to check for both values?
@crutonjohn
Copy link

didn't see the contribfest label on this one, but i'm working on this anyways :)

@TylerHelmuth TylerHelmuth added the chart:collector Issue related to opentelemetry-collector helm chart label Nov 15, 2024
crutonjohn added a commit to crutonjohn/opentelemetry-helm-charts that referenced this issue Nov 15, 2024
@crutonjohn
fix(collector): introduce or conditional to enable the deployment of …
d66946d 
…PodMonitor

PodMonitor was not being deployed because this logic was not in place.

open-telemetry#1379
crutonjohn added a commit to crutonjohn/opentelemetry-helm-charts that referenced this issue Nov 16, 2024
@crutonjohn
fix(collector): only render PrometheusRule when ServiceMonitor is dep…
d2d253a 
…loyed

this fixes a regression introduced by myself in my last commit

open-telemetry#1379
@crutonjohn crutonjohn mentioned this issue Nov 16, 2024
Closed
crutonjohn added a commit to crutonjohn/opentelemetry-helm-charts that referenced this issue Nov 16, 2024
@crutonjohn
fix(collector): prometheusRule should render when specified
ba5fd56 
this fixes a regression i introduced related to rendering the PrometheusRule conditions. it should
now render in a wide array of scenarios.

open-telemetry#1379
@crutonjohn crutonjohn linked a pull request Nov 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chart:collector Issue related to opentelemetry-collector helm chart
Projects
None yet
Milestone
No milestone
3 participants
@TylerHelmuth @lindeskar @crutonjohn