Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape exemplar keys to fix invalid key errors #5995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Escape exemplar keys to fix invalid key errors #5995

wants to merge 1 commit into from

Conversation

dashpole
Copy link
Contributor

Fixes #5936

@dashpole dashpole changed the title Sanitize exemplar keys to fix invalid key errors Escape exemplar keys to fix invalid key errors Nov 21, 2024
@dashpole dashpole mentioned this pull request Nov 21, 2024
Open
@dashpole dashpole added the bug Something isn't working label Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (99c3c66) to head (5644ee0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5995     +/-   ##
=======================================
- Coverage   82.1%   82.1%   -0.1%     
=======================================
  Files        273     273             
  Lines      23615   23616      +1     
=======================================
  Hits       19400   19400             
- Misses      3870    3871      +1     
  Partials     345     345

see 3 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus - Exemplar label name is invalid when filtering attributes in a custom view
1 participant
@dashpole