Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/log: Introduce EnabledParameters #5810

Closed
pellared opened this issue Sep 12, 2024 · 1 comment · May be fixed by #5816
Closed

sdk/log: Introduce EnabledParameters #5810

pellared opened this issue Sep 12, 2024 · 1 comment · May be fixed by #5816
Assignees
@pellared
Labels
area:logs Part of OpenTelemetry logs pkg:SDK Related to an SDK package

Comments

@pellared
Copy link
Member

pellared commented Sep 12, 2024 •
edited
Loading

I think that in the SDK package there should be a separate EnabledParameters type that includes more information and have getters for resource.Resource, instrumentation.Scope, trace.TraceID, trace.SpanID, trace.TraceFlags. Similarly like we have a separate Record type in SDK which includes this information.

Blocked by:

Originally posted by @pellared in #5791 (comment)
@pellared pellared added pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs labels Sep 12, 2024
@pellared pellared self-assigned this Sep 12, 2024
@pellared pellared mentioned this issue Sep 12, 2024
Merged
@pellared pellared moved this from Todo to In Progress in Go: Logs (GA) Sep 13, 2024
@pellared pellared moved this from In Progress to Todo in Go: Logs (GA) Sep 13, 2024
@pellared pellared mentioned this issue Sep 13, 2024
Draft
@pellared pellared moved this from Todo to Backlog in Go: Logs (GA) Sep 19, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Sep 19, 2024

Closing for now.

@MrAlias MrAlias closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Go: Logs (GA) Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area:logs Part of OpenTelemetry logs pkg:SDK Related to an SDK package
Projects
Go: Logs (GA)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Spike] sdk/log: Add Logger.Enabled and EnabledParameters pellared/opentelemetry-go
2 participants
@pellared @MrAlias