Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Runtime] .NET 9 updates and future plans #2071

Closed
joegoldman2 opened this issue Sep 14, 2024 · 8 comments · Fixed by #2339
Closed

[Instrumentation.Runtime] .NET 9 updates and future plans #2071

joegoldman2 opened this issue Sep 14, 2024 · 8 comments · Fixed by #2339
Assignees
@stevejgordon
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime good first issue Good for newcomers help wanted Extra attention is needed
Milestone
MicrosoftTeam-1.10.0

Comments

@joegoldman2
Copy link
Contributor

With the introduction of built-in runtime metrics in .NET 9 (dotnet/runtime#104680), I wanted to understand the future plans for OpenTelemetry.Instrumentation.Runtime. Specifically:

  • Will the package continue to be maintained and supported for .NET version before 9?
  • Are there any plans to phase it out for users who are using .NET 9 or newer?
@Kielek
Copy link
Contributor

Kielek commented Sep 17, 2024

@twenzel, @xiang17 FYI

@Kielek
Copy link
Contributor

Kielek commented Sep 17, 2024

I would say, that we should keep this package.

For .NET Framework and .NET8 (I assume that .NET6 will be removed) we should keep current behavior. For .NET9+ we should register System.Runtime in meter.

We have similar behavior for AspNetCore already.

@twenzel
Copy link
Contributor

twenzel commented Sep 17, 2024

@Kielek sounds good to me.

@xiang17
Copy link
Contributor

xiang17 commented Sep 18, 2024

Agree to keep current behavior for existing use cases.

@CodeBlanch CodeBlanch added comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime good first issue Good for newcomers help wanted Extra attention is needed labels Sep 23, 2024
@CodeBlanch
Copy link
Member

I'm assuming since the issue isn't assigned to anyone that @twenzel @xiang17 neither of you are actively working on this?

I added "help wanted" tag.

For anyone who wants to pick this up, it sounds like we need to...

  • Update the code to call AddMeter("System.Runtime") when running on .NET 9+. The existing logic should only run when NOT on .NET 9+.

  • Update README with information similar to what we have for AspNetCore.

@CodeBlanch CodeBlanch changed the title [Instrumentation.Runtime] Future plans [Instrumentation.Runtime] .NET 9 updates and future plans Sep 23, 2024
@CodeBlanch CodeBlanch added this to the MicrosoftTeam-Future milestone Sep 24, 2024
@manishrw
Copy link

@CodeBlanch I can take it up if it's available.

@Kielek Kielek mentioned this issue Nov 14, 2024
Closed
@stevejgordon
Copy link
Contributor

@manishrw Did you take this any further? I'd be able to pick this up if not.

@Kielek
Copy link
Contributor

Kielek commented Nov 19, 2024

@stevejgordon, There is a silence in more than one month. Feel free to take it.

@Kielek Kielek assigned stevejgordon and unassigned manishrw Nov 19, 2024
@stevejgordon stevejgordon mentioned this issue Nov 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevejgordon stevejgordon

Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
MicrosoftTeam-1.10.0
7 participants
@twenzel @manishrw @stevejgordon @Kielek @xiang17 @CodeBlanch @joegoldman2