Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric instrumentation for Redis client #1742

Open
cijothomas opened this issue Nov 2, 2021 · 2 comments
Open

Metric instrumentation for Redis client #1742

cijothomas opened this issue Nov 2, 2021 · 2 comments
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis enhancement New feature or request

Comments

@cijothomas
Copy link
Member

Similar to: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs
@cijothomas cijothomas added the enhancement New feature or request label Nov 2, 2021
@cijothomas
Copy link
Member Author

spec incoming: https://github.com/open-telemetry/opentelemetry-specification/pull/2070/files

@reyang reyang transferred this issue from open-telemetry/opentelemetry-dotnet May 13, 2024
@reyang reyang added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label May 13, 2024
@tiagodaraujo tiagodaraujo mentioned this issue Jul 30, 2024
Closed
4 tasks
@tiagodaraujo
Copy link

I opened the PR #1982 to resolve this issue, I don't know if it was the best process. I added 3 new metrics with the same tracing attributes that follow the semantic convention.

Can anyone help me to understand the next steps or even what steps I skipped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Instrumentation.StackExchangeRedis] Metrics support tiagodaraujo/opentelemetry-dotnet-contrib
3 participants
@cijothomas @tiagodaraujo @reyang