Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/scraperhelper] Confirm intended side effects of scraper.ID deprecation. #11691

Open
TylerHelmuth opened this issue Nov 18, 2024 · 0 comments
Open

[receiver/scraperhelper] Confirm intended side effects of scraper.ID deprecation. #11691

TylerHelmuth opened this issue Nov 18, 2024 · 0 comments
Assignees
@bogdandrutu @dmitryax
Labels
area:receiver

Comments

@TylerHelmuth
Copy link
Member

Description

In #11659 Scraper.ID was deprecated in favor of AddScraperWithType. During the v0.114.0 release I found that this was an incompatible switch for the hostmetric receiver's factory tests.

The hostmetrics receiver is testing factory.CreateMetricsScraper which returns a scraperhelper.Scraper and is not calling scraperhelper.NewScraperControllerReceiver so scraperhelper.AddScraperWithType isn't an option. To move forward with the release I removed the test's use of Scraper.ID`.

Was this an intended outcome of the change? If so this issue can be closed.

Related: open-telemetry/opentelemetry-collector-contrib#36395 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdandrutu bogdandrutu

@dmitryax dmitryax

Labels
area:receiver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bogdandrutu @dmitryax @TylerHelmuth