Add optional headers to DownloadableFile messages when downloading files #306
Conversation
tigrannajaryan
changed the title
|
The build fails because we need to update to the new version of Protobufs that have the new Headers field. This PR does it #307 |
|
Please rebase, it should fix the build. |
|
Rebase done @tigrannajaryan |
|
@RichardChukwu ICYMI, the test failure logs.
you can verify the changes locally by running |
Thanks, working on it already |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage ? 77.11%
=======================================
Files ? 25
Lines ? 2307
Branches ? 0
=======================================
Hits ? 1779
Misses ? 423
Partials ? 105 ☔ View full report in Codecov by Sentry. |
|
Hi @RichardChukwu, are you still working on this? |
Fixes #299
This PR implements the recent specification change that allows for optional headers in the DownloadableFile message, which can be used during file downloads to support authentication and other header-based configurations.
The downloadFile function in the packagesSyncer struct has been modified to include optional headers from the DownloadableFile message. This enhancement allows Agents to set custom HTTP headers when downloading files from the server. For instance, headers such as Authorization can now be included to facilitate secure downloads.
Changes Made:
-Updated the downloadFile method to check for the presence of optional headers in the DownloadableFile message.
-Added logic to incorporate these headers into the HTTP request when downloading files.
-Ensured compatibility with the updated protocol specification that outlines the use of headers for authentication and other purposes.