You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this case, it makes sense to just collapse the directory to:
path/to/ @jpmcb
since all files under that tree are owned by that person. There are probably 1000 and 1 edge cases on this so it'll be critical to think through the data structures and the algorithms for how this would work. Likely, off the top of my head, we'd probably want to take a tree traversal approach where we go deep first over breadth.
The text was updated successfully, but these errors were encountered:
Filtering and collapsing directories while generating the CODEOWNERS file would be ideal, but would increase the complexity of designing this feature.
It'd have to be after the file tree with its codeowners has been calculated: this is technically a graph traversal problem and you can't know which nodes to collapse unless you've visited all nodes. This comes with its own challenges sine the internal structure of how the codeowners is calculated isn't really built around this graph / tree idea (and it really should be).
Suggested solution
Right now, the code owners generation will granularly denote codeowners for each file in the git tree:
In this case, it makes sense to just collapse the directory to:
since all files under that tree are owned by that person. There are probably 1000 and 1 edge cases on this so it'll be critical to think through the data structures and the algorithms for how this would work. Likely, off the top of my head, we'd probably want to take a tree traversal approach where we go deep first over breadth.
The text was updated successfully, but these errors were encountered: