-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Fix all jsx-a11y plugin warnings #4139
Comments
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue. For full info on how to contribute, please check out our contributors guide. |
I've self-assigned this to just track the overarching issue. |
@FatumaA, if you want to drive this whole effort, let me know, and I can assign this overarching issue to you. |
I would love to do that! |
@nickytonline Can I contribute to some of this issues |
@FatumaA is driving this effort, but go for it.
|
@FatumaA I would love to help with these. Let me know where I can jump in. 🙂 |
Hi Michaella, Please take a look at any of the linked issues above that don't have the triage label and that are not assigned to anyone else. You can claim any such issues by commenting ".take" on it. Please take one issue at a time |
Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. |
1 similar comment
Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. |
This is an overarching issue to oversee all the fixes that the jsx-a11y eslint plugin has surfaced.
Note when fixing an issue, for example an onClick on a div, use a native button element instead of adding all the event handlers and
aria-*
attributes to fix the issue. Native elements like a button handle focus events, etc.Please tackle one issue at a time so others can contribute as well.
Tasks:
Once all these issues are fixed, the last thing to do is to set the jsx-a11y plugin to error instead of warn. See #4110
The text was updated successfully, but these errors were encountered: