Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: need to validate goals prior to network calls #38

Open
2 tasks done
mtfoley opened this issue May 31, 2022 · 5 comments · May be fixed by #39
Open
2 tasks done

Bug: need to validate goals prior to network calls #38

mtfoley opened this issue May 31, 2022 · 5 comments · May be fixed by #39
Assignees
Labels
🐛 bug Something isn't working

Comments

@mtfoley
Copy link
Contributor

mtfoley commented May 31, 2022

Describe the bug

If goals repos do not conform to repo full name conventions, data updates to stars etc will fail.

Steps to reproduce

Create an issue in the goals repo without using the full name convention. Wait for scheduled actions to show failures/errors.

will also happen if a renovatebot is used on the goals repo, since it creates an issue called “Dependency Dashboard”

https://docs.renovatebot.com/key-concepts/dashboard/

Screenshot of error message
9F168754-30E7-4B83-91C5-A1B6DD4DD57D

Cc @takanome-dev

Affected services

opensauced.pizza

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@mtfoley mtfoley added the 🐛 bug Something isn't working label May 31, 2022
@takanome-dev
Copy link

Hey @mtfoley I'm also using renovatebot. Do you think that's the issue??

@mtfoley
Copy link
Contributor Author

mtfoley commented May 31, 2022

I do think that's probably it, yes. However, the actions repo should take that possibility into account.

@bdougie
Copy link
Member

bdougie commented May 31, 2022

This should catch or skip those issues, here

@mtfoley
Copy link
Contributor Author

mtfoley commented May 31, 2022

Assigned @takanome-dev per the discussion in the Discord.

@0-vortex
Copy link
Contributor

This should catch or skip those issues, here

Was thinking about a .then(issues => {}) iterator and excluding issues not created by open sauced integration a little bit above that:

stagedIssues = await octokit.rest.issues.listForRepo({
owner: login,
repo: "open-sauced-goals"
})

@takanome-dev takanome-dev linked a pull request May 31, 2022 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants