Fix importing types on Node 16 module resolution #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Could you squash and sign-off, please, so we can get this merged? Details here |
Signed-off-by: Phillip Huang <[email protected]>
Signed-off-by: Phillip Huang <[email protected]>
Signed-off-by: Phillip Huang <[email protected]>
JavaScriptBach
force-pushed
the
phillip-export-types
branch
from
1a9203e
to
17a330c
Compare
JavaScriptBach
commented
Jun 9, 2024
Comment on lines
+45
to
+46
| mv $outdir/types/opa.d.ts $outdir/types/opa.d.mts | ||
| cp $outdir/types/opa.d.mts $outdir/types/opa.d.cts |
There was a problem hiding this comment.
Unfortunately separate declaration files are required. Otherwise, typescript will assume the types are either ESM or CJS depending on the value of the type field of the nearest package.json.
|
Any updates on getting this merged? |
|
Hello @srenatus - is there anything I can do to help get this out? |
|
@JavaScriptBach Are you around? To get this merged, it'll need your sign-off. |
|
Oh wait, this has sign-offs on each commit. Nevermind. I'll take care of rebasing and pushing a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
I upgraded my TypeScript moduleResolution to Node 16, and TypeScript stopped being able to find the types. This change should fix it.