Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move emitAdmissionEvents and emitAuditEvents to beta #3442

Open
DorB-P opened this issue Jul 4, 2024 · 4 comments
Open

move emitAdmissionEvents and emitAuditEvents to beta #3442

DorB-P opened this issue Jul 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@DorB-P
Copy link
Contributor

DorB-P commented Jul 4, 2024

Describe the solution you'd like
This issue is to discuss the reasons why these are still in alpha. Any blocker to move to beta?

Anything else you would like to add:
Later on, I'd like to emit allow admission events as well #3440 . Would love to hear your thoughts on the matter - issues/limitations you can think of.

Thanks

@DorB-P DorB-P added the enhancement New feature or request label Jul 4, 2024
@ritazh
Copy link
Member

ritazh commented Jul 5, 2024

No major concerns from me to move it to beta.

Copy link

stale bot commented Sep 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 4, 2024
@stale stale bot closed this as completed Sep 18, 2024
@ritazh ritazh reopened this Sep 18, 2024
@ritazh
Copy link
Member

ritazh commented Sep 18, 2024

@maxsmythe @sozercan wdyt?

@ritazh ritazh removed the stale label Sep 18, 2024
@maxsmythe
Copy link
Contributor

Do we have a target use case for these given the limitations (e.g. expectation of throttling)? Do we expect the API to change in any way?

Move from alpha to beta is gated on API stability and confidence that feature will not go away. (Not suggesting that feature will go away, just dunno if we've revisited the use case given events' non-viability for full state xfer due to throttling).

Expectations of throttling would be increased if we added support for admission events, since that would increase the frequency of event admission (dependent on QPS to K8s API server).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants