Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set labels on Deployment #3429

Open
DanTulovsky opened this issue Jun 21, 2024 · 4 comments
Open

Add ability to set labels on Deployment #3429

DanTulovsky opened this issue Jun 21, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DanTulovsky
Copy link

Describe the solution you'd like

Much like we can set labels on pods with podLabels it would be useful to have the ability to set labels on the Deployment objects as well. For example, we would like to set a app.kubernetes.io/name label on the Deployment and there is no way to do this with the existing chart.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Gatekeeper version: All
  • Kubernetes version: (use kubectl version): All
@DanTulovsky DanTulovsky added the enhancement New feature or request label Jun 21, 2024
Copy link

stale bot commented Aug 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 21, 2024
@stale stale bot closed this as completed Sep 4, 2024
@DanTulovsky
Copy link
Author

This doesn't look like it's completed...

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: '{{ template "gatekeeper.name" . }}'
    chart: '{{ template "gatekeeper.name" . }}'
    control-plane: controller-manager
    gatekeeper.sh/operation: webhook
    gatekeeper.sh/system: "yes"
    heritage: '{{ .Release.Service }}'
    release: '{{ .Release.Name }}'
  name: gatekeeper-controller-manager
  namespace: '{{ .Release.Namespace }}'

@ritazh ritazh reopened this Sep 5, 2024
@stale stale bot removed the stale label Sep 5, 2024
@ritazh
Copy link
Member

ritazh commented Sep 5, 2024

It got closed due to staleness.

For anyone who is interested in adding this, PTAL how pod labels were add for inspiration: https://github.com/open-policy-agent/gatekeeper/pull/3378/files

@ritazh ritazh added the good first issue Good for newcomers label Sep 5, 2024
@prakrit55
Copy link

@ritazh, I am interested to contribute, could you assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants