Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for fields within AddressNL component #4420

Closed
LaurensBurger opened this issue Jun 19, 2024 · 5 comments · Fixed by open-formulieren/formio-builder#167, open-formulieren/types#51, open-formulieren/open-forms-sdk#701 or #4598
Closed

Validation for fields within AddressNL component #4420

LaurensBurger opened this issue Jun 19, 2024 · 5 comments · Fixed by open-formulieren/formio-builder#167, open-formulieren/types#51, open-formulieren/open-forms-sdk#701 or #4598
Assignees
@stevenbal
Labels
enhancement owner: utrecht
Milestone
Release 2.8.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Jun 19, 2024 •
edited
Loading

Thema / Theme

Form designer

Omschrijving / Description

to add to: #4418

Currently forms might be validating on the "city" and "postcode" fields. The AddressNL component does not seem to support validation on the fields within the component.

If this validation is lost these forms would have no way of using both the AddressNL component and BAG plugin.
@LaurensBurger LaurensBurger added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jun 19, 2024
@sergei-maertens
Copy link
Member

Which validations can you do now that you can't do in the AddressNL field?

@LaurensBurger
Copy link
Collaborator Author

Only allow form te be filled in by residents of "Sergei City". If i don't have authentication/prefill for a form i would apply validation to the city field to achieve this.
image

@sergei-maertens
Copy link
Member

Okay, so a regex validation on individual nested fields would suffice then, I presume? And of course being able to specify validation error messages.

@LaurensBurger
Copy link
Collaborator Author

Yes - that sounds sufficient

@sergei-maertens sergei-maertens mentioned this issue Jun 24, 2024
Open
7 tasks
@joeribekker
Copy link
Contributor

Refinement: Allow regex on city and postal code.

@joeribekker joeribekker added owner: utrecht and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jun 24, 2024
This was referenced Jul 8, 2024
Merged
Closed
stevenbal added a commit to open-formulieren/types that referenced this issue Jul 8, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] AddressNL component validation
82d50e9 
updated the addressNL componentschema to include components, where we define the validation for the fields under the addressNL component. It's defined under component to have a similar form as other formio components
@stevenbal stevenbal mentioned this issue Jul 8, 2024
Merged
stevenbal added a commit to open-formulieren/formio-builder that referenced this issue Jul 8, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Field validation for AddressNL
a47cf07 
the following components can now be validated using regex:
* postcode
* house number
* street name
* city
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Jul 9, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AdressNL fields
c604e03
@stevenbal stevenbal mentioned this issue Jul 9, 2024
Merged
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Jul 9, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
9105878
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Jul 9, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
f27ffa2
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Jul 9, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
ee06357
stevenbal added a commit to open-formulieren/formio-builder that referenced this issue Jul 9, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Field validation for AddressNL
5f1d2e7 
the following components can now be validated using regex:
* postcode
* city
stevenbal added a commit to open-formulieren/types that referenced this issue Jul 9, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] AddressNL component validation
b2f753a 
updated the addressNL componentschema to include components, where we define the validation for the fields under the addressNL component. It's defined under component to have a similar form as other formio components
stevenbal added a commit to open-formulieren/types that referenced this issue Jul 9, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] AddressNL component validation
fa2b85e 
updated the addressNL componentschema to include components, where we define the validation for the fields under the addressNL component. It's defined under component to have a similar form as other formio components
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Jul 29, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
05498ee
stevenbal added a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal
💬 [open-formulieren/open-forms#4420] Run makemessages
f3e73a6
stevenbal added a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal
👌 [open-formulieren/open-forms#4420] PR feedback
6e8e3b5 
* use prefix for AddressNL SubcomponentValidation and useManageValidatorsTranslations
* remove unnecessary waitFor blocks in AddressNL stories
* add aria-label to datamap
stevenbal added a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal
⬆️ [open-formulieren/open-forms#4420] Upgrade types to 0.28.0
27f9624
stevenbal added a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal
💬 [open-formulieren/open-forms#4420] Run makemessages
65e171e
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
✨ [open-formulieren/open-forms#4420] Field validation for AddressNL
44dd77d 
the following components can now be validated using regex:
* postcode
* city
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
✅ [open-formulieren/open-forms#4420] Stories for AddressNL validation
4a7e1fa
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
👌 [open-formulieren/open-forms#4420] PR feedback
3b039d4 
* use prefix for AddressNL SubcomponentValidation and useManageValidatorsTranslations
* remove unnecessary waitFor blocks in AddressNL stories
* add aria-label to datamap
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
💬 [open-formulieren/open-forms#4420] Run makemessages
a431899
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
✨ [open-formulieren/open-forms#4420] Field validation for AddressNL
f14c4ac 
the following components can now be validated using regex:
* postcode
* city
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
✅ [open-formulieren/open-forms#4420] Stories for AddressNL validation
f802ab8
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
👌 [open-formulieren/open-forms#4420] PR feedback
ab472ef 
* use prefix for AddressNL SubcomponentValidation and useManageValidatorsTranslations
* remove unnecessary waitFor blocks in AddressNL stories
* add aria-label to datamap
sergei-maertens pushed a commit to open-formulieren/formio-builder that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
💬 [open-formulieren/open-forms#4420] Run makemessages
e1f504b
sergei-maertens pushed a commit that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
✨ [#4420] Backend validation for AddressNL components
94f566b 
implemented optional custom regex validation on the AddressNL postcode and city fields. Previously this was possible before the AddressNL field existed as well
sergei-maertens pushed a commit that referenced this issue Aug 20, 2024
@stevenbal @sergei-maertens
✅ [#4420] Add tests for AddressNL component validation
7bff2b2
sergei-maertens added a commit that referenced this issue Aug 20, 2024
@sergei-maertens
⬆️ [#4420] Bump to formio-builder 0.28.0
32b819d
sergei-maertens added a commit that referenced this issue Aug 20, 2024
@sergei-maertens
Merge pull request #4598 from open-formulieren/feature/4420-addressnl…
780993a 
…-validation

✨ [#4420] Backend validation for AddressNL components
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Aug 26, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
59c90a6
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 16, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
dba3556
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 16, 2024
@stevenbal
♻️ [open-formulieren/open-forms#4420] Use zod for addressNL validation
e008597
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 16, 2024
@stevenbal
♻️ [open-formulieren/open-forms#4420] Use zod for addressNL validation
db417a3
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 16, 2024
@stevenbal
♻️ [open-formulieren/open-forms#4420] Use zod for addressNL validation
e2ae335
stevenbal added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 16, 2024
@stevenbal
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
34b18de
sergei-maertens pushed a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 8, 2024
@stevenbal @sergei-maertens
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
c24924f
sergei-maertens pushed a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 8, 2024
@stevenbal @sergei-maertens
✨ [open-formulieren/open-forms#4420] Validation for AddressNL fields
03cf8b1
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Oct 8, 2024
@sergei-maertens
Merge pull request #701 from open-formulieren/feature/4420-addressNL-…
103d1ab 
…nested-field-validation

✨ [open-formulieren/open-forms#4420] Validation for AdressNL fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
enhancement owner: utrecht
Projects
Development
Archived in project
Milestone
Release 2.8.0
4 participants
@joeribekker @sergei-maertens @stevenbal @LaurensBurger