Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Events-Storage-Area #3

Open
opdt opened this issue Nov 17, 2022 · 3 comments
Open

Add Events-Storage-Area #3

opdt opened this issue Nov 17, 2022 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@opdt
Copy link
Owner

opdt commented Nov 17, 2022

Implement events with cassandra-storage. As we don't use Keycloak-authorization ourselves, we would be happy to get help with this.

@opdt opdt added enhancement New feature or request help wanted Extra attention is needed labels Nov 17, 2022
@xgp
Copy link

xgp commented Jan 3, 2024

Happy to take this one. I have a start on this https://github.com/opdt/keycloak-cassandra-extension/compare/main...xgp:keycloak-cassandra-extension:xgp/event-store?expand=1

I'm currently working through a few issues with loading the stored events into the Admin UI, but all of the storage methods are working properly.

Let me know what you expect in terms of tests for a PR you would accept.

@opdt
Copy link
Owner Author

opdt commented Jan 4, 2024

Let me know what you expect in terms of tests for a PR you would accept.

Our strategy so far was to copy model-layer tests from Keycloak and use them to validate our storage-implementation.

@xgp xgp mentioned this issue Jan 9, 2024
@xgp
Copy link

xgp commented Jan 9, 2024

Thanks. I ported the tests from Keycloak. I submitted a DRAFT PR with some outstanding issues. Would love some feedback when you have the time. #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants