-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Merge back unblob-native into this repo #1034
Comments
I'm all for it. The most sensitive part will be porting unblob-native CI here and converting the current CI/CD pipeline definitions to use Personally I'm all for limiting duplicate work. Right now the flake updates, the dependency upgrades from dependabot, the project settings, everything is done twice and it's annoying. |
Not sure what's your take but I'd be happy to try |
I'm a fan of monorepos, they are a productivity boost. I would have not split the repo first place, but I wasn't here to prevent it 😀 |
If we are to do this, we need to get off of Poetry for sure. Tried various ways, but there is still no way to build abi3 wheels with it, and there is no way to use a different builder. Renovate would be nice, as we could integrate flake lock updates into it as well. |
We don't have to immediately integrate everything, the first step can be to just merge the two repos, later we can move to uv or whatever needed for a more seamless workflow. |
IMO, it would be easier the other way around: migrate to |
Will look into it. I've tried |
Ok this is crazy. uv is so fast I needed to try it manually because I thought nothing happened. |
The Unblob rust extension started its life as an opt-in piece in this repo. We extracted it into its own package due to (1) limitations in Poetry packaging native extensions, and (2) the higher barrier of entry people needed to build Unblob.
maturin
builder in pyproject.toml to build wheels+1: Refactors, like dropping support for Python 3.8, wouldn't be missing the
unblob-native
part :o)It looks like, we'd need to switch Poetry for
maturin
oruv
for installing the project environment as well, if we want to avoid having a separate build output.The text was updated successfully, but these errors were encountered: