[UR][Bindless] Initial implementation of bindless images for HIP #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeWeb
force-pushed
the
georgi/bindless-hip
branch
3 times, most recently
from
a89b779 to
0912559
Compare
|
@oneapi-src/unified-runtime-hip-write , @oneapi-src/unified-runtime-bindless-images-write Heyo, that's a whole lot of changes and additions, so I am just pinging as a reminder in case it was lost in messages over the Winter holidays. There is no rush in reviewing immediately, I just wanted to remind about it. Thank you! |
frasercrmck
reviewed
Jan 15, 2025
GeorgeWeb
force-pushed
the
georgi/bindless-hip
branch
2 times, most recently
from
78766a6 to
9996c42
Compare
This PR implements the entry points in the HIP adapter for the Bindless Images extension. Some features, while implemented, only partially pass the End-to-end tests for them in DPC++ (the PR that enables the support and testing in DPC++: intel/llvm#16439). This is because the HIP runtime doesn't support, for example, some parameter combinations with some image memory types. The not-fully supported features are marked with TODOs in the device info queries for further work. Signed-off-by: Georgi Mirazchiyski <[email protected]> Co-authored-by: Peter Žužek <[email protected]>
GeorgeWeb
force-pushed
the
georgi/bindless-hip
branch
from
9996c42 to
d0c8716
Compare
@frasercrmck Firstly, apologies for the delay in addressing the feedback. Now this feedback was actually quite thorough and I really appreciate it, so thank you for this! |
frasercrmck
approved these changes
Jan 29, 2025
DBDuncan
approved these changes
Jan 29, 2025
ldrumm
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 6, 2025
…on HIP (#16439) This PR implements the required spirv builtins in the libclc for AMD targets to support fetching (excluding sampled fetch for now), sampling, and writing for images and image arrays. Additionally, End-to-end tests are updated to require the aspects corresponding to the feature that is being tested from the Bindless Images extension. This helps avoid having to manually say which backend adapter is supported or unsupported and instead rely on support based on aspect/device queries to drive the execution of the tests. HIP adapter implementation in UR: oneapi-src/unified-runtime#2496 Signed-off-by: Georgi Mirazchiyski <[email protected]> --------- Signed-off-by: Georgi Mirazchiyski <[email protected]> Signed-off-by: JackAKirk <[email protected]> Co-authored-by: JackAKirk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the entry points in the HIP adapter for the Bindless Images extension.
Some features, while implemented, only partially pass the End-to-end tests for them in DPC++ (the PR that enables the support and testing in DPC++: intel/llvm#16439). This is because the HIP runtime doesn't support, for example, some parameter combinations with some image memory types. The not-fully supported features are marked with
TODOs in the device info queries for further work.Signed-off-by: Georgi Mirazchiyski [email protected]
Co-authored-by: Peter Žužek [email protected]