Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to retry download API #365

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix to retry download API #365

merged 1 commit into from
Oct 24, 2023

Conversation

konkapv
Copy link
Collaborator

@konkapv konkapv commented Oct 23, 2023

Pull requests into this repository require the following checks to be completed by the submitter and reviewers.

Fix to rety download API if the response is not OK.

Submitter:

  • Administrative tasks are complete.
    • This pull request describes why these changes were made.
    • The JIRA ticket links to this PR.
    • The JIRA ticket for this PR is:
  • Tests are complete.
    • Tests are included and test edge cases.
    • Tests have been run locally and pass.
  • Code review has been performed.
    • Code diff has been done and checked to ensure only expected code is being committed.
    • A linter for the language has been run.

Primary Reviewer:

  • Code works.
    • Code has been run locally and the basic functionality affected by the PR has been checked.
    • Edge cases have been checked to ensure behavior is as expected.
  • Code review has been performed.
    • Code is maintainable, reusable, efficient, and correct.
    • Code accomplishes the tasks purpose.
    • Code follows style guidance appropriate for the language, including passing linter checks.
    • Code is well commented (which does not mean verbosely commented).
  • Tests are complete.
    • Tests are included and test edge cases.
    • Tests have been run locally and pass.

Merger:

Prior to merging, ensure that all checks have been completed. Delete the branch after the merge
is complete.

@konkapv konkapv requested a review from pwbarker October 23, 2023 17:01
@pwbarker pwbarker merged commit 7f45bf2 into main Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants