Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Require child chain transactions to include confirmations #31

Open
DavidKnott opened this issue Feb 28, 2018 · 1 comment
Open

Require child chain transactions to include confirmations #31

DavidKnott opened this issue Feb 28, 2018 · 1 comment
Labels
standard

Comments

@DavidKnott
Copy link
Contributor

Currently users can spend transactions without having received a confirmation, this should not be allowed.

Add a check to child_chain.py to make sure that the transactions being referenced as inputs have valid confirmations.
@DavidKnott DavidKnott changed the title Require child chain transactions to include confirmations. Require child chain transactions to include confirmations Feb 28, 2018
@smartcontracts smartcontracts self-assigned this Apr 28, 2018
@smartcontracts
Copy link
Contributor

I think the easiest way to handle this is to have the transaction confirmation be included as an input to apply_transaction. Does that make sense?

deckmon added a commit to deckmon/plasma-mvp that referenced this issue Jun 30, 2018
@deckmon
Merge pull request omgnetwork#31 from deckmon/master
50fca24 
snapshot rotate
@smartcontracts smartcontracts removed their assignment Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
standard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smartcontracts @DavidKnott