Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful handling of (Net, Joy) Controller Disconnects #796

Open
Nopey opened this issue Nov 30, 2024 · 0 comments
Open

Graceful handling of (Net, Joy) Controller Disconnects #796

Nopey opened this issue Nov 30, 2024 · 0 comments

Comments

@Nopey
Copy link
Contributor

Nopey commented Nov 30, 2024

Controllers often disconnect:

  • Remote network players lose connection or desync
  • Joysticks physically disconnect

Current behavior* is to end the match & return to the main menu when the EVENT_TYPE_CLOSE event occurs, which is not great.
Would be nice if we could pull open a "Controller Disconnected" dialog, and allow the players to quit or for the player to rejoin** with a different** controller

* tested in arena. i melee/vs might fail in a different way?
** rejoining makes sense for local games, but sounds difficult to do in network games.

EDIT: edited this issue to be focused on just "what do we do when the controller disappears," rather than an assorted collection of thoughts on "how do we joystick better?"

I would prefer if the "Choose Input Device" had a single option for joysticks: "JOYSTICK."
Selecting "JOYSTICK" would take the player to a live list of detected joysticks, including some information on what each joystick is: name, make/model, whether a button is currently being pressed, and any other useful information SDL readily provides us.

Issue 499 is relevant, and is higher priority because it's a bug. Not directly linking here because I don't want a backlink from 499 to this lower priority issue.

Rebinding joystick buttons may be nice to have, but is probably not worthwhile at this time.

are there any other known ambitions for joystick support?

@Nopey Nopey changed the title Joystick Quality of Life Graceful handling of (Net, Joy) Controller Disconnects Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant