Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug on master: mounted? breaks in adv optimization #894

Open
awkay opened this issue Nov 24, 2017 · 0 comments
Open

Bug on master: mounted? breaks in adv optimization #894

awkay opened this issue Nov 24, 2017 · 0 comments

Comments

@awkay
Copy link
Contributor

awkay commented Nov 24, 2017

The hack into react internals isn't going to work at least with React 15.6. I fixed this in Fulcro 2.0 by reimplementing mounted via lifecycle hooks (componentDidMount and componentWillUnmount) instead of trying to look for private data on the React component internals.

See https://github.com/fulcrologic/fulcro/blob/d11725c456dc4b0d0f7a1b5cb9d14e5e4cb0dbf6/src/main/fulcro/client/primitives.cljc#L206

A similar patch should fix in on Om Next.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awkay