Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events setup crashes on time with sub seconds #310

Open
osteele opened this issue May 5, 2018 · 1 comment
Open

events setup crashes on time with sub seconds #310

osteele opened this issue May 5, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@osteele
Copy link
Contributor

osteele commented May 5, 2018

The event list at/views/board and /views/events should be sorted by date.

Multiday events should be sorted as though their start date were max(event.start, now.start_of_day).

@osteele osteele added this to the Finals week milestone May 5, 2018
@osteele osteele added bug and removed enhancement labels May 5, 2018
@osteele osteele self-assigned this May 5, 2018
@osteele
Copy link
Contributor Author

osteele commented May 5, 2018

The actual issue was that one of the events ("Infrastructure Workshop Course Exhibition", May 12–17, id=5aecfb808c031300180f75f4) had an end date with sub-second accuracy (2018-05-17 03:59:59.999000), that Date.parse can't handle.

I've added a workaround to truncate the subseconds. (Not rounding, just because it's easier and I don't know where the fix should really go.)

@osteele osteele changed the title Events should be sorted Events setup crashes on time with sub seconds May 5, 2018
@osteele osteele changed the title Events setup crashes on time with sub seconds events setup crashes on time with sub seconds May 5, 2018
osteele added a commit that referenced this issue May 9, 2018
SeunginLyu pushed a commit that referenced this issue May 10, 2018
* Fix README markdown lint errors and typos
* Reorganize README; remove sudo from npm start
* Convert tabs to spaces in api.js
* Simplify the eslintrc
* Add travis config
* Lint the markdown
* Switch from npm to yarn
For consistency with abe-web. Also, because yarn is better :-).
* Lint js files in static
* Fix trivial lint errors
Semicolons, mixed spaces and tabs, one of the unused variables
* Add a Travis badge
* Fix lint errors in board_events.js
Since I'm going to be working here
* Teach server to display listening address in URL form, so I can click on it
* Workaround for #310 events setup crashes on time with sub seconds
* Update views url
* Add expo UI, Update video background to black
* Update css for expo UI
* Fix css error in upload.cscs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant