Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme files can they be hosted by us #169

Open
anantshri opened this issue May 26, 2023 · 0 comments
Open

Theme files can they be hosted by us #169

anantshri opened this issue May 26, 2023 · 0 comments

Comments

@anantshri
Copy link
Contributor

Right now when we select a theme from plugin UI a web url is marked in the .env which means every build there is a call to the weburl for fetching the file.

My suggestions is that we can download the url once and place the theme in repository itself. So effectively once user selects the theme we fetch theme and commit it to code.

This

  1. Saves regular bandwidth usage and occasional error when github url's misbehave or dont give a 200 ok results.
  2. If the author of the theme does any major change I would not get a surprise coz i just added a note and my site broke.

The edge case being if the theme is updated how would we get an update. that could be something to be handled.
a. Either we assume when we downloaded the css thats the point in time snapshot it will not change
b. provide a mechanism to identify if we have theme deviation and if we want to update the theme.
c. Simply reselecting or updating the settings page can trigger the file download and upload action so if there is any change file gets an upgrade.

Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant