You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now when we select a theme from plugin UI a web url is marked in the .env which means every build there is a call to the weburl for fetching the file.
My suggestions is that we can download the url once and place the theme in repository itself. So effectively once user selects the theme we fetch theme and commit it to code.
This
Saves regular bandwidth usage and occasional error when github url's misbehave or dont give a 200 ok results.
If the author of the theme does any major change I would not get a surprise coz i just added a note and my site broke.
The edge case being if the theme is updated how would we get an update. that could be something to be handled.
a. Either we assume when we downloaded the css thats the point in time snapshot it will not change
b. provide a mechanism to identify if we have theme deviation and if we want to update the theme.
c. Simply reselecting or updating the settings page can trigger the file download and upload action so if there is any change file gets an upgrade.
Any thoughts?
The text was updated successfully, but these errors were encountered:
Right now when we select a theme from plugin UI a web url is marked in the .env which means every build there is a call to the weburl for fetching the file.
My suggestions is that we can download the url once and place the theme in repository itself. So effectively once user selects the theme we fetch theme and commit it to code.
This
The edge case being if the theme is updated how would we get an update. that could be something to be handled.
a. Either we assume when we downloaded the css thats the point in time snapshot it will not change
b. provide a mechanism to identify if we have theme deviation and if we want to update the theme.
c. Simply reselecting or updating the settings page can trigger the file download and upload action so if there is any change file gets an upgrade.
Any thoughts?
The text was updated successfully, but these errors were encountered: