Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 6 Support #10

Closed
colinodell opened this issue Feb 17, 2022 · 3 comments
Closed

Symfony 6 Support #10

colinodell opened this issue Feb 17, 2022 · 3 comments

Comments

@colinodell
Copy link
Contributor

I'd love to see support for Symfony 6 in this library :)

@michelv
Copy link

michelv commented Apr 27, 2022

Seconded.

That support implies some upgrades in the require-dev section, as Symfony 6 requires PHP 8 and the PHPunit version that's used here is limited to PHP 7.

It may also imply dropping support for Symfony 4.4 or rewriting some of the tests, because some FrameworkBundle config options aren't available anymore starting from Symfony 5.3 (at least framework.session.storage_id has been replaced by .storage_factory_id).

@Chris53897
Copy link

I did a quick look and started a PR. There is more to change. Drop support for php 7 and symfony 4 will make a lot of things easier. I can say more after a closer look.

@vtsykun
Copy link
Member

vtsykun commented Oct 5, 2024

Fixed in #14

@vtsykun vtsykun closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants