Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition is augmenting incorrect module #144

Open
richmason opened this issue Sep 17, 2024 · 1 comment
Open

Type definition is augmenting incorrect module #144

richmason opened this issue Sep 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@richmason
Copy link

richmason commented Sep 17, 2024

Describe the bug

The src/types/index.ts file is augmenting @vue/runtime-core instead of vue. Please see the Vue docs for Augmenting Global Properties.

Also, please see the 4.4.1 patch release notes for vue-router that addresses this same issue, and warns that other packages will also need to update their code.

Reproduction Steps?

I am having the same problem as mentioned in this issue:
intlify/vue-i18n#1919 (comment)

The only sub-dependency that is still augmenting @vue/runtime-core instead of vue in my codebase is okta-vue.

SDK Versions

System:

  • OS: macOS 14.6.1
  • CPU: (10) arm64 Apple M1 Pro
  • Memory: 419.14 MB / 32.00 GB
  • Shell: 5.9 - /bin/zsh

Binaries:

  • Node: 20.12.0 - ~/.nvm/versions/node/v20.12.0/bin/node
  • Yarn: 1.22.22 - ~/.nvm/versions/node/v20.12.0/bin/yarn
  • npm: 10.8.2 - ~/.nvm/versions/node/v20.12.0/bin/npm
  • pnpm: 9.10.0 - ~/.nvm/versions/node/v20.12.0/bin/pnpm
  • bun: 1.1.8 - ~/.bun/bin/bun

Browsers:

  • Chrome: 128.0.6613.138
  • Safari: 17.6

npmPackages:

  • @okta/okta-auth-js: ^7.8.0 => 7.8.0
  • @okta/okta-vue: ^5.7.0 => 5.7.0
  • @vue/compiler-sfc: ^3.5.6 => 3.5.6
  • vue: ^3.5.6 => 3.5.6
  • vue-eslint-parser: ^9.4.3 => 9.4.3
  • vue-good-table-next: ^0.2.2 => 0.2.2
  • vue-i18n: 10.0.1 => 10.0.1
  • vue-router: ^4.4.5 => 4.4.5
  • vue-toastification: ^2.0.0-rc.5 => 2.0.0-rc.5
  • vue-tsc: ^2.1.6 => 2.1.6
  • vue3-datepicker: ^0.4.0 => 0.4.0
  • vue3-perfect-scrollbar: ^1.6.1 => 1.6.1

Additional Information

No response

@richmason richmason added the bug Something isn't working label Sep 17, 2024
@jaredperreault-okta
Copy link
Contributor

Thanks for the report

Internal Ref: OKTA-805968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants