Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design updates November 2023 #48

Open
6 of 7 tasks
amercader opened this issue Nov 14, 2023 · 3 comments
Open
6 of 7 tasks

Design updates November 2023 #48

amercader opened this issue Nov 14, 2023 · 3 comments
Assignees

Comments

@amercader
Copy link
Member

amercader commented Nov 14, 2023

Cosmetic changes to match the design after the latest OKFN rebranding:

@gocemitevski gocemitevski self-assigned this Nov 16, 2023
@gocemitevski
Copy link
Member

gocemitevski commented Nov 16, 2023

@amercader the Open Knowledge Foundation Panel plugin is currently not compatible with the new theme assets and needs to be updated, if not rewritten. This is something that Keitaro cannot do as part of these updates. Everything else is done and deployed to https://blog.okfn.org/.

@amercader
Copy link
Member Author

Thanks @gocemitevski !

Regarding the collapsible panel, would it be possible to just add the necessary markup to the relevant theme layout template? It's just a matter to add these lines in the page template, we don't need all the WP config interface that the WP plugin included

<head>
   <!-- ... -->
    <link rel="stylesheet" href="https://a.okfn.org/html/oki/panel/assets/css/frontend.css"/>
    <style>
      #ok-panel {
        border-color:#2D2D2D
      }
      #ok-panel-wrapper {
        float:right
      }
      #ok-panel-wrapper:not([data-breakpoint*='px'])>.ok-ribbon {
        margin-top:0;
        background-color:#2D2D2D;
        margin-bottom:1.5em;
        background-color:transparent
      }
    </style>
<!-- ... -->
<head>

  <body>
    <div id="ok-panel" class="closed"><div class="container"><iframe src="https://a.okfn.org/html/oki/panel/panel.html" scrolling="no"></iframe></div></div>
    <div id="ok-panel-wrapper"><a class="white ok-ribbon" href="https://okfn.org/"><img src="https://a.okfn.org/html/oki/panel/assets/images/oki-ribbon.png" alt="Open Knowledge"></a></div>

<!-- ... -->

  <script src="https://a.okfn.org/html/oki/panel/assets/js/frontend.js" type="text/javascript"></script>
</body>

@gocemitevski
Copy link
Member

@amercader unfortunately not. I already tried to do that. This is basically the same code generated by the WordPress plugin, but with the newly updated assets based on the new version of the panel.

https://github.com/okfn/okf-panel/blob/master/inc/sunrise/assets.php
https://github.com/okfn/okf-panel/blob/master/inc/plugin-actions.php

The problems are caused by small differences in the styling rules and JavaScript assets. Just adding the above code snippet in the header.php template of wordpress-theme will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants