Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository logos #15

Open
sapetti9 opened this issue Nov 10, 2022 · 4 comments
Open

Repository logos #15

sapetti9 opened this issue Nov 10, 2022 · 4 comments

Comments

@sapetti9
Copy link
Collaborator

sapetti9 commented Nov 10, 2022

The logos on the projects in the Repository should all be the same size.

ATM they are all different:
Schermata 2022-11-10 alle 16 00 58
But ideally we want the pink line to be always at the same level.

@aivuk
Copy link
Collaborator

aivuk commented Nov 17, 2022

@sapetti9 I changed to have the space where we put the logos as fixed and the same for all logos. The logos are going to have different sizes because the images that we are using have different sizes, but all the pink lines now are aligned.

@sapetti9
Copy link
Collaborator Author

Line aligned is already one good thing. Can't we have a rule to have all images with similar size? Also, the same logo appears in different sizes now:
Schermata 2022-11-17 alle 13 18 00

@aivuk
Copy link
Collaborator

aivuk commented Nov 17, 2022

the difference in size is because the area where the logo is placed has a size based on 50% of the card size. But the card size is based on the row, as you can see above the first row is taller than the down row. The only way to fix that would be fixing the size of the cards.

Can't we have a rule to have all images with similar size?

we can have all the images with same size but this is not going to solve the problem because the logo images have different margins and sizes. The only way would be to edit the images to all have the same format.

@sapetti9
Copy link
Collaborator Author

Ok, I'll make sure all logos have the same size and re-upload them in the repo. Can we please have all the cards in the same size though? I think it is strange that they have different sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants