Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-cloud-okd repo hard coded with 4.14 version #55

Open
jcapiitao opened this issue Sep 29, 2023 · 3 comments
Open

sig-cloud-okd repo hard coded with 4.14 version #55

jcapiitao opened this issue Sep 29, 2023 · 3 comments

Comments

@jcapiitao
Copy link
Contributor

The release in sig-cloud-okd repo is hardcoded which is consumed by all the releases pipelines.
I guess it's not critical currently as 4.15 may not diverged too much from 4.14, but it might be in the future.

We can fix it with a sed 's/4.14/4.15/' alike command after the cosa-init execution as we do for the RPM artifacts

sed -i 's/rhel-9.*-server-ose.*/artifacts/' $(readlink -f src/config/manifest-$(params.variant).yaml)

The second option is to define the whole repo and add it at the end of src/config/c9s.repo as we do for artifacts
cat <<EOF >> src/config/c9s.repo
[artifacts]
name=OKD RPM artifacts
baseurl=file:///workspace/coreos/rpms/
repo_gpgcheck=0
gpgcheck=0
enabled=1
EOF

This option is better aligned with the layerd build effort #46 as, IIUC, the sig-cloud-okd repo definition in src/config/c9s.repo will be removed at the end (to separate SCOS and OKD).

But we first need to tag the builds in the cloud9s-okd-4.15-release tag
I can do the tags, and even build the new NVRs but I'd need the exact version of what's in 4.15 release

@jcapiitao
Copy link
Contributor Author

Actually, based on this commit openshift/os@b157aa7 I think we should rename the sig-cloud-okd repo to sig-cloud-okd-X.Y for the sake of consistency.
And then in cosa-init task, edit it to whatever release defined in task.

@LorbusChris
Copy link
Contributor

Thanks for raising this! I'm not really a fan of doing these downstream sed hacks, but it's certainly an option.

And yes, we definitely need the CBS builds tag.

Related: openshift/os#1375

@jcapiitao
Copy link
Contributor Author

Do you want me to take care of the CBS tags ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants