-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot reload, column total votes, refactorings #18
Open
Utopism
wants to merge
25
commits into
ojde:master
Choose a base branch
from
Smile-SA:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modifié : assets/javascripts/view_issues_vote.js
modifié : db/migrate/001_create_vote_on_issues.rb
modifié : lib/vote_on_issues/patches/query_patch.rb
modifié : assets/stylesheets/view_issues_vote.css
modifié : app/models/vote_on_issue.rb
modifié : config/locales/en.yml
modifié : config/locales/de.yml
renommé : lib/query_column.rb -> app/models/voi_query_column.rb
detail : use Rails.configuration.to_prepare to permit hot reload downgrades version_or_higher to Redmine 2.6.10 query_column -> voi_query_column add sum_votes_up_and_dn column modifié : init.rb
ActiveRecord::RecordNotFound exception replaced by test modifié : app/controllers/vote_on_issues_controller.rb
supprimé : app/helpers/vote_on_issues_helper.rb
renommé : app/views/view_issues/_show_details_bottom.erb -> app/views/issues/view_issues/_show_details_bottom.erb
renommé : app/views/issues/view_issues/_show_details_bottom.erb -> app/views/issues/_show_details_bottom.erb
modifié : app/views/issues/_show_details_bottom.erb
modifié : app/views/issues/_show_details_bottom.erb nouveau fichier : app/views/issues/_votes.html.erb
copié : app/views/issues/_show_details_bottom.erb -> app/views/issues/_my_votes.html.erb modifié : app/views/issues/_show_details_bottom.erb
modifié : app/views/issues/_show_details_bottom.erb
modifié : lib/hooks.rb
modifié : app/models/voi_query_column.rb
modifié : app/models/vote_on_issue.rb
modifié : app/views/vote_on_issues/show_voters.js.erb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Can you review this pull request ? Thanks a lot.