Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload, column total votes, refactorings #18

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Utopism
Copy link

@Utopism Utopism commented May 10, 2019

Hi,

Can you review this pull request ? Thanks a lot.

  • use Rails.configuration.to_prepare to permit hot reload
  • downgrades version_or_higher to Redmine 2.6.10
  • query_column -> voi_query_column
  • added sum_votes_up_and_dn column
  • Refactoring to respect the rails conventions

Lxc and others added 25 commits May 9, 2019 23:57
modifié :         assets/javascripts/view_issues_vote.js
modifié :         db/migrate/001_create_vote_on_issues.rb
modifié :         lib/vote_on_issues/patches/query_patch.rb
modifié :         assets/stylesheets/view_issues_vote.css
modifié :         config/locales/en.yml
modifié :         config/locales/de.yml
modifié :         README.rdoc
renommé :         lib/query_column.rb -> app/models/voi_query_column.rb
detail :
use Rails.configuration.to_prepare to permit hot reload
downgrades version_or_higher to Redmine 2.6.10
query_column -> voi_query_column
add sum_votes_up_and_dn column
modifié :         init.rb
ActiveRecord::RecordNotFound exception replaced by test
modifié :         app/controllers/vote_on_issues_controller.rb
supprimé :        app/helpers/vote_on_issues_helper.rb
nouveau fichier : config/locales/fr.yml
renommé :         app/views/view_issues/_show_details_bottom.erb -> app/views/issues/view_issues/_show_details_bottom.erb
renommé :         app/views/issues/view_issues/_show_details_bottom.erb -> app/views/issues/_show_details_bottom.erb
modifié :         app/views/issues/_show_details_bottom.erb
modifié :         app/views/issues/_show_details_bottom.erb
nouveau fichier : app/views/issues/_votes.html.erb
copié :           app/views/issues/_show_details_bottom.erb -> app/views/issues/_my_votes.html.erb
modifié :         app/views/issues/_show_details_bottom.erb
modifié :         app/views/issues/_show_details_bottom.erb
modifié :         changelog
modifié :         init.rb
modifié :         app/models/voi_query_column.rb
modifié :         app/models/vote_on_issue.rb
modifié :         app/views/vote_on_issues/show_voters.js.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant