Avoid invalid length when building name symbol (#348) #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use strlen instead of calculation on dr->buf to manage both strings with and without \0 last character. Add tests on last element closed not opened (aka orphan).
ohler55
reviewed
Mar 3, 2024
| @@ -984,7 +984,7 @@ static char read_element_end(SaxDrive dr) { | |||
| } else { | |||
| snprintf(msg, sizeof(msg) - 1, "%selement '%s' closed but not opened", EL_MISMATCH, dr->buf.str); | |||
| ox_sax_drive_error_at(dr, msg, pos, line, col); | |||
| name = str2sym(dr, dr->buf.str, dr->buf.tail - dr->buf.str - 2, 0); | |||
| name = str2sym(dr, dr->buf.str, strlen(dr->buf.str), 0); | |||
There was a problem hiding this comment.
As you pointed out, dr->buf.str may not be null terminated which will give an incorrect length. A different approach will be needed to handle when the end tag is empty if the existing code fails. It seems like it should work though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to avoid shorten element name or error on last closed not opened (aka orphan) element reported into #348.
Fixes #348