Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick group by paradigm #11

Open
oelarnes opened this issue Jan 9, 2025 · 0 comments
Open

Pick group by paradigm #11

oelarnes opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@oelarnes
Copy link
Owner

oelarnes commented Jan 9, 2025

Not really a bug, but an unintuitive interaction:

It's possible to use context to define a column that is an attribute of the pick field, which can be tagged as a group_by or pick_sum. If used as a group_by, then any name_sum columns provided from the draft will group by that column (but not "pick") and then pivot to be tagged with the name associated to the column. This results in a Cartesian product of card names with pick attributes.

The paradigm that currently works is to identify such columns as "pick_sum" columns and divide by num_taken in the agg step. This could be improved.

@oelarnes oelarnes added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant