Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to implement OAuth with Deno Fresh #2535

Open
austenstone opened this issue Sep 15, 2023 · 3 comments
Open

How to implement OAuth with Deno Fresh #2535

austenstone opened this issue Sep 15, 2023 · 3 comments
Labels
deno Type: Support Any questions, information, or general needs around the SDK or GitHub APIs

Comments

@austenstone
Copy link

I'm curious how we would properly implement OAuth web flow with the Deno Fresh framework?

It seems the web flow is heavily dependent on the middlewear. Could we somehow utilize this with Fresh middlewear??

I see Octokit has a way to get the token manually but I'm struggling to import @octokit/oauth-app in Deno world.

Here's my go at it:
https://github.com/austenstone/fresh-github-oauth/tree/new

@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 added Type: Support Any questions, information, or general needs around the SDK or GitHub APIs deno labels Sep 15, 2023
@wolfy1339
Copy link
Member

What kind of errors are you getting while importing @octokit/oauth-app?

We may be able to fix some of them.

One important pointer for using Octokit in deno, don't import the package directly from NPM, use esm.sh

@wolfy1339
Copy link
Member

@austenstone Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deno Type: Support Any questions, information, or general needs around the SDK or GitHub APIs
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

2 participants