Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: When will the conversion to ESM happen? #434

Closed
1 task done
ollie-iterators opened this issue Jan 6, 2023 · 1 comment
Closed
1 task done

[FEAT]: When will the conversion to ESM happen? #434

ollie-iterators opened this issue Jan 6, 2023 · 1 comment
Labels
Type: Support Any questions, information, or general needs around the SDK or GitHub APIs

Comments

@ollie-iterators
Copy link

Describe the need

I have noticed that there are lots of Pull Requests, like #425 that are said to be blocked because of the need to use ESM in the modules. I also notice that ESM-ifying the repositories is the next step to be done in the plan to separate types from code and make the types composable/extendable (Shown in octokit/octokit.js#2127)

SDK Version

Octokit.rb v6.0.0

API Version

ex v1.1.1

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ollie-iterators ollie-iterators added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jan 6, 2023
@wolfy1339
Copy link
Member

Progress is happening, slowly.
We aren't just simply migrating to ESM, some modules are being rewritten, split up

See https://github.com/octokit/octokit-next.js

@wolfy1339 wolfy1339 added Type: Support Any questions, information, or general needs around the SDK or GitHub APIs and removed Type: Feature New feature or request Status: Triage This is being looked at and prioritized labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Support Any questions, information, or general needs around the SDK or GitHub APIs
Projects
Archived in project
Development

No branches or pull requests

2 participants