You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, we always iterate through all the available drives calling the expensive _get_drive_root operation. The list drive object is actually a generator, but we turn it to a dictionary anyway which executes the entire generator.
there's caches to the method calls in question, but it doesn't really help because the standard API for using tentaclio is via tio.open, which creates a new client each time anyway, meaning the cache is useless
We should:
only iterate through drives until we find the right one
only call the expensive _get_drive_root method on that specific drive
needs a little bit of refactoring to do this cleanly
The text was updated successfully, but these errors were encountered:
At the moment, we always iterate through all the available drives calling the expensive
_get_drive_root
operation. The list drive object is actually a generator, but we turn it to a dictionary anyway which executes the entire generator.there's caches to the method calls in question, but it doesn't really help because the standard API for using tentaclio is via
tio.open
, which creates a new client each time anyway, meaning the cache is uselessWe should:
_get_drive_root
method on that specific driveneeds a little bit of refactoring to do this cleanly
The text was updated successfully, but these errors were encountered: