Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App doesn't require access to all the permission it supports in the trust policy file #581

Open
irizzant opened this issue Oct 31, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@irizzant
Copy link

The list of available permissions to ask in a trust policy file is wider than the one requested by the installed app.

See for example security_events, which is not accessible by the app

"name": "security_events",

@mattmoor
Copy link
Collaborator

Yes, because this field's type literally comes from Google's library for the GitHub API, so the permissions we would need to ask for is "literally everything".

We plan to do quarterly releases and roll up new permissions into those releases (since it requires folks to hit "re-install" on the app), so if you have requests for permissions you need, please let us know.

@cpanato did we document ☝️ somewhere?

@cpanato cpanato self-assigned this Nov 1, 2024
@cpanato
Copy link
Contributor

cpanato commented Nov 1, 2024

no, i will do that

@cpanato cpanato added the documentation Improvements or additions to documentation label Nov 1, 2024
@irizzant
Copy link
Author

irizzant commented Nov 1, 2024

@mattmoor thanks for the reply, I'd request permissions for access

  • security_events
  • vulnerability_alerts
  • secret_scanning_alerts
  • checks

which are in general security releated aspects that one may need to access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants